Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Sync Clippings settings dialog, hyperlinks don't open in new browser tab #507

Open
aecreations opened this issue Oct 25, 2024 · 2 comments
Assignees

Comments

@aecreations
Copy link
Owner

Clippings 7.0rc4

When a user has an older version of Sync Clippings Helper installed, the "Download now" link appears in the Sync Clippings settings dialog. But clicking on it opens the link in the current tab.

@aecreations aecreations self-assigned this Oct 25, 2024
@aecreations
Copy link
Owner Author

This is also an unresolved bug with the link to the Sync Clippings page that appears in the Sync Clippings settings dialog if the user doesn't have the native messaging app installed.

There is an event handler for hyperlinks in the extension preferences page that causes clicks on them to open in a new browser tab. But the event handler is defined before the links in the Sync Clippings settings dialog, which are shown or hidden dynamically at runtime, not during page initialization.

@aecreations aecreations changed the title In Sync Clippings settings dialog, "Download Now" link doesn't open in new window In Sync Clippings settings dialog, hyperlinks don't open in new browser tab Oct 25, 2024
@aecreations
Copy link
Owner Author

Workaround: CTRL+click on the hyperlink to cause it to open in a new tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant