Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shortcut key list incorrectly includes clippings in subfolders of deleted folders #55

Open
aecreations opened this issue Jan 17, 2021 · 4 comments
Open

Shortcut key list incorrectly includes clippings in subfolders of deleted folders #55

aecreations opened this issue Jan 17, 2021 · 4 comments
Assignees
@aecreations
Labels
bug Something isn't working

Comments

@aecreations
Copy link
Owner

Clippings 6.0a3+

The background script that supplies the data for the shortcut key list naïvely gets all clippings that don't exist in the "secret" deleted clippings folder. This results in the shortcut key list showing invalid clippings.

This should be changed so that folders are recursively processed, starting from the root folder, to gather all clippings that have shortcut keys.
@aecreations aecreations added the bug Something isn't working label Jan 17, 2021
@aecreations aecreations added this to the 6.0b1 milestone Jan 17, 2021
@aecreations aecreations self-assigned this Jan 17, 2021
@aecreations aecreations modified the milestones: 6.0b1, 6.0b2, 6.0rc1 Feb 27, 2021
@aecreations aecreations modified the milestones: 6.0rc1, 6.0b1, 6.0b2 Mar 9, 2021
@aecreations
Copy link
Owner Author

Cannot reproduce.

Clippings Manager removes the shortcut key assignment on a clipping when it is deleted, so it should never be picked up by the shortcut key list.

@aecreations aecreations removed this from the 6.0b2 milestone Mar 13, 2021
@aecreations aecreations removed the bug Something isn't working label Mar 13, 2021
@aecreations
Copy link
Owner Author

Reopening. This issue occurs if the parent folder of a clipping with a shortcut key assigned is deleted.

@aecreations aecreations added the bug Something isn't working label Mar 13, 2021
@aecreations aecreations added this to the 6.0b2 milestone Mar 13, 2021
@aecreations aecreations reopened this Mar 13, 2021
@aecreations
Copy link
Owner Author

Fixing this will be difficult, as clippings and folders are stored in separate tables in the IndexedDB database. Will need to consider a refactor of the data structure in a future version of Clippings.

@aecreations aecreations removed this from the 6.0b2 milestone Mar 14, 2021
@aecreations
Copy link
Owner Author

Also, this issue also exists in Clippings for Firefox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aecreations aecreations

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aecreations