Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sc-65908] Work around some schema improvements #74

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

tomascasas
Copy link

@tomascasas tomascasas commented Nov 27, 2024

This one includes a few changes to support:

  • Assets' paths
  • Ad schema attached to the '/v1/flight/{flightId}/creative' path
  • Job paths and expanding its schema

@tomascasas tomascasas changed the title Tomascasas/sc 65908/create a schema helper [sc-65908] Work around some schema improvements Nov 27, 2024
@tomascasas tomascasas force-pushed the tomascasas/sc-65908/create-a-schema-helper branch from 7a50904 to 4a2a760 Compare November 27, 2024 18:41
@tomascasas tomascasas marked this pull request as ready for review November 28, 2024 01:20
This seems slightly redundant based on testing.
The AdBase seems to accept additional properties by default.
Keeping it avoid potential defaults being different where consumed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant