-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sc-65908] Work around some schema improvements #74
Open
tomascasas
wants to merge
14
commits into
master
Choose a base branch
from
tomascasas/sc-65908/create-a-schema-helper
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomascasas
changed the title
Tomascasas/sc 65908/create a schema helper
[sc-65908] Work around some schema improvements
Nov 27, 2024
tomascasas
force-pushed
the
tomascasas/sc-65908/create-a-schema-helper
branch
from
November 27, 2024 18:41
7a50904
to
4a2a760
Compare
tomascasas
force-pushed
the
tomascasas/sc-65908/create-a-schema-helper
branch
from
November 27, 2024 21:40
ebc709f
to
2240260
Compare
This seems slightly redundant based on testing. The AdBase seems to accept additional properties by default. Keeping it avoid potential defaults being different where consumed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one includes a few changes to support:
'/v1/flight/{flightId}/creative'
path