Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Make icons great again!! #4960

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TarunAdobe
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Nov 27, 2024

⚠️ No Changeset found

Latest commit: f76df4f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@TarunAdobe TarunAdobe force-pushed the ttomar/make-icons-great-again branch 2 times, most recently from a923199 to e2511e8 Compare November 27, 2024 11:12
Copy link

Branch preview

Review the following VRT differences

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

@coveralls
Copy link
Collaborator

coveralls commented Nov 27, 2024

Pull Request Test Coverage Report for Build 12066036412

Details

  • 61 of 61 (100.0%) changed or added relevant lines in 5 files are covered.
  • 47 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 98.063%

Files with Coverage Reduction New Missed Lines %
packages/iconset/src/iconset-svg.ts 47 63.92%
Totals Coverage Status
Change from base Build 12031482906: -0.1%
Covered Lines: 32147
Relevant Lines: 32612

💛 - Coveralls

Copy link

github-actions bot commented Nov 27, 2024

Lighthouse scores

Category Latest (report) Main (report) Branch (report)
Performance 0.99 0.98 0.97
Accessibility 1 1 1
Best Practices 1 1 1
SEO 1 0.92 0.92
PWA 1 1 1
What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category Latest Main Branch
Total 250.587 kB 236.86 kB 🏆 236.935 kB
Scripts 60.784 kB 54.396 kB 54.253 kB 🏆
Stylesheet 53.772 kB 48.017 kB 🏆 48.18 kB
Document 6.224 kB 5.464 kB 🏆 5.519 kB
Font 126.812 kB 126.633 kB 126.631 kB 🏆

Request Count

Category Latest Main Branch
Total 52 52 52
Scripts 41 41 41
Stylesheet 5 5 5
Document 1 1 1
Font 2 2 2

Copy link

github-actions bot commented Nov 27, 2024

Tachometer results

Chrome

accordion permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 678 kB 91.11ms - 92.39ms - faster ✔
15% - 17%
16.45ms - 18.70ms
branch 682 kB 108.41ms - 110.26ms slower ❌
18% - 20%
16.45ms - 18.70ms
-

action-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 739 kB 54.68ms - 56.49ms - faster ✔
3% - 7%
1.77ms - 3.90ms
branch 713 kB 57.86ms - 58.98ms slower ❌
3% - 7%
1.77ms - 3.90ms
-

action-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 814 kB 77.38ms - 78.81ms - faster ✔
5% - 8%
3.91ms - 6.46ms
branch 768 kB 82.23ms - 84.34ms slower ❌
5% - 8%
3.91ms - 6.46ms
-

action-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 836 kB 49.42ms - 51.00ms - faster ✔
6% - 10%
3.04ms - 5.55ms
branch 791 kB 53.53ms - 55.47ms slower ❌
6% - 11%
3.04ms - 5.55ms
-

action-menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 959 kB 144.73ms - 147.94ms - faster ✔
3% - 5%
3.91ms - 8.25ms
branch 913 kB 150.96ms - 153.87ms slower ❌
3% - 6%
3.91ms - 8.25ms
-

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 917 kB 72.22ms - 73.44ms - faster ✔
5% - 7%
3.76ms - 5.77ms
branch 872 kB 76.79ms - 78.39ms slower ❌
5% - 8%
3.76ms - 5.77ms
-

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 916 kB 70.97ms - 72.12ms - faster ✔
5% - 8%
3.57ms - 5.85ms
branch 871 kB 75.27ms - 77.24ms slower ❌
5% - 8%
3.57ms - 5.85ms
-

test-open-close-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.09 MB 1876.79ms - 1879.53ms - unsure 🔍
-0% - +0%
-1.32ms - +2.63ms
branch 1.04 MB 1876.09ms - 1878.93ms unsure 🔍
-0% - +0%
-2.63ms - +1.32ms
-

test-open-close permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.09 MB 1881.05ms - 1884.42ms - unsure 🔍
-0% - +0%
-0.84ms - +3.81ms
branch 1.04 MB 1879.66ms - 1882.84ms unsure 🔍
-0% - +0%
-3.81ms - +0.84ms
-

alert-banner permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 689 kB 14.14ms - 14.34ms - faster ✔
2% - 4%
0.27ms - 0.62ms
branch 662 kB 14.54ms - 14.83ms slower ❌
2% - 4%
0.27ms - 0.62ms
-

alert-dialog permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 739 kB 109.79ms - 111.51ms - faster ✔
1% - 3%
1.05ms - 3.08ms
branch 696 kB 112.17ms - 113.26ms slower ❌
1% - 3%
1.05ms - 3.08ms
-

breadcrumbs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 979 kB 521.53ms - 526.24ms - faster ✔
3% - 4%
13.97ms - 23.09ms
branch 932 kB 538.51ms - 546.32ms slower ❌
3% - 4%
13.97ms - 23.09ms
-

button-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 731 kB 45.46ms - 46.56ms - faster ✔
6% - 9%
2.78ms - 4.29ms
branch 688 kB 49.03ms - 50.06ms slower ❌
6% - 9%
2.78ms - 4.29ms
-

button permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 739 kB 52.74ms - 54.12ms - faster ✔
4% - 7%
2.19ms - 4.09ms
branch 694 kB 55.91ms - 57.23ms slower ❌
4% - 8%
2.19ms - 4.09ms
-

card permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 781 kB 38.88ms - 39.72ms - faster ✔
2% - 5%
0.81ms - 1.95ms
branch 771 kB 40.29ms - 41.07ms slower ❌
2% - 5%
0.81ms - 1.95ms
-

checkbox permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 680 kB 46.21ms - 47.36ms - faster ✔
7% - 9%
3.33ms - 4.79ms
branch 670 kB 50.39ms - 51.29ms slower ❌
7% - 10%
3.33ms - 4.79ms
-

coachmark permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 910 kB 93.44ms - 95.61ms - faster ✔
4% - 6%
3.58ms - 6.50ms
branch 862 kB 98.59ms - 100.54ms slower ❌
4% - 7%
3.58ms - 6.50ms
-

color-field permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 748 kB 46.58ms - 47.38ms - faster ✔
9% - 11%
4.46ms - 5.55ms
branch 755 kB 51.62ms - 52.34ms slower ❌
9% - 12%
4.46ms - 5.55ms
-

combobox permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 1 MB 42.37ms - 43.11ms - faster ✔
1% - 3%
0.36ms - 1.29ms
branch 989 kB 43.28ms - 43.86ms slower ❌
1% - 3%
0.36ms - 1.29ms
-

light-dom-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1 MB 407.06ms - 413.57ms - slower ❌
8% - 11%
30.82ms - 40.59ms
branch 989 kB 370.96ms - 378.25ms faster ✔
8% - 10%
30.82ms - 40.59ms
-

contextual-help permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 944 kB 53.80ms - 54.93ms - faster ✔
7% - 9%
3.99ms - 5.64ms
branch 896 kB 58.57ms - 59.78ms slower ❌
7% - 10%
3.99ms - 5.64ms
-

dialog permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 802 kB 81.74ms - 82.97ms - unsure 🔍
-1% - +0%
-1.10ms - +0.24ms
branch 757 kB 82.53ms - 83.05ms unsure 🔍
-0% - +1%
-0.24ms - +1.10ms
-

field-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 686 kB 45.67ms - 47.14ms - faster ✔
1% - 5%
0.58ms - 2.48ms
branch 676 kB 47.32ms - 48.55ms slower ❌
1% - 5%
0.58ms - 2.48ms
-

field-label permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 651 kB 22.55ms - 22.93ms - faster ✔
2% - 5%
0.58ms - 1.12ms
branch 625 kB 23.39ms - 23.78ms slower ❌
3% - 5%
0.58ms - 1.12ms
-

help-text permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 646 kB 12.36ms - 12.54ms - faster ✔
2% - 4%
0.23ms - 0.47ms
branch 620 kB 12.71ms - 12.88ms slower ❌
2% - 4%
0.23ms - 0.47ms
-

icon permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 651 kB 14.96ms - 15.97ms - slower ❌
10% - 17%
1.32ms - 2.37ms
branch 626 kB 13.49ms - 13.76ms faster ✔
9% - 15%
1.32ms - 2.37ms
-

infield-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 661 kB 16.97ms - 17.27ms - faster ✔
6% - 9%
1.13ms - 1.63ms
branch 636 kB 18.30ms - 18.70ms slower ❌
7% - 10%
1.13ms - 1.63ms
-

menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 741 kB 212.63ms - 219.75ms - unsure 🔍
-3% - +0%
-6.55ms - +1.02ms
branch 709 kB 217.67ms - 220.25ms unsure 🔍
-0% - +3%
-1.02ms - +6.55ms
-

meter permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 668 kB 50.45ms - 51.01ms - faster ✔
4% - 6%
2.30ms - 3.32ms
branch 641 kB 53.11ms - 53.96ms slower ❌
5% - 7%
2.30ms - 3.32ms
-

number-field permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 795 kB 74.85ms - 76.22ms - faster ✔
9% - 11%
7.09ms - 9.64ms
branch 799 kB 82.83ms - 84.97ms slower ❌
9% - 13%
7.09ms - 9.64ms
-

overlay permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 982 kB 433.81ms - 436.47ms - faster ✔
1% - 2%
3.69ms - 8.02ms
branch 937 kB 439.28ms - 442.70ms slower ❌
1% - 2%
3.69ms - 8.02ms
-

directive-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.06 MB 26.29ms - 26.74ms - faster ✔
6% - 9%
1.63ms - 2.45ms
branch 1.02 MB 28.21ms - 28.90ms slower ❌
6% - 9%
1.63ms - 2.45ms
-

element-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.05 MB 357.17ms - 361.56ms - faster ✔
2% - 4%
8.59ms - 15.27ms
branch 1.01 MB 368.78ms - 373.82ms slower ❌
2% - 4%
8.59ms - 15.27ms
-

lazy-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 851 kB 45.11ms - 45.98ms - faster ✔
7% - 9%
3.26ms - 4.65ms
branch 805 kB 48.96ms - 50.04ms slower ❌
7% - 10%
3.26ms - 4.65ms
-

picker-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 674 kB 29.87ms - 30.32ms - faster ✔
5% - 8%
1.72ms - 2.51ms
branch 647 kB 31.89ms - 32.53ms slower ❌
6% - 8%
1.72ms - 2.51ms
-

picker permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 817 kB 518.12ms - 525.29ms - faster ✔
2% - 4%
8.02ms - 19.77ms
branch 771 kB 530.95ms - 540.26ms slower ❌
2% - 4%
8.02ms - 19.77ms
-

popover permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 817 kB 107.23ms - 110.20ms - faster ✔
0% - 3%
0.19ms - 3.28ms
branch 771 kB 110.03ms - 110.88ms slower ❌
0% - 3%
0.19ms - 3.28ms
-

progress-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 666 kB 30.73ms - 31.22ms - faster ✔
3% - 5%
0.96ms - 1.72ms
branch 640 kB 32.02ms - 32.60ms slower ❌
3% - 6%
0.96ms - 1.72ms
-

radio permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 663 kB 38.20ms - 38.82ms - faster ✔
3% - 5%
1.19ms - 2.14ms
branch 639 kB 39.81ms - 40.54ms slower ❌
3% - 6%
1.19ms - 2.14ms
-

search permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 737 kB 43.97ms - 45.33ms - faster ✔
3% - 7%
1.62ms - 3.36ms
branch 741 kB 46.60ms - 47.69ms slower ❌
4% - 8%
1.62ms - 3.36ms
-

slider permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 741 kB 78.80ms - 80.19ms - faster ✔
4% - 7%
3.53ms - 5.89ms
branch 715 kB 83.25ms - 85.16ms slower ❌
4% - 7%
3.53ms - 5.89ms
-

swatch permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 669 kB 15.74ms - 16.24ms - faster ✔
6% - 10%
1.12ms - 1.77ms
branch 643 kB 17.22ms - 17.65ms slower ❌
7% - 11%
1.12ms - 1.77ms
-

switch permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 657 kB 16.96ms - 17.28ms - faster ✔
5% - 8%
0.97ms - 1.42ms
branch 633 kB 18.16ms - 18.48ms slower ❌
6% - 8%
0.97ms - 1.42ms
-

table permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 802 kB 126.81ms - 129.74ms - faster ✔
8% - 10%
11.03ms - 14.78ms
branch 767 kB 140.01ms - 142.35ms slower ❌
9% - 12%
11.03ms - 14.78ms
-

tabs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 683 kB 114.95ms - 116.29ms - faster ✔
1% - 2%
0.90ms - 2.69ms
branch 658 kB 116.81ms - 118.01ms slower ❌
1% - 2%
0.90ms - 2.69ms
-

tags permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 712 kB 14.91ms - 15.11ms - unsure 🔍
-3% - +2%
-0.43ms - +0.25ms
branch 686 kB 14.77ms - 15.43ms unsure 🔍
-2% - +3%
-0.25ms - +0.43ms
-

textfield permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 693 kB 26.31ms - 26.82ms - faster ✔
7% - 9%
1.95ms - 2.71ms
branch 700 kB 28.61ms - 29.18ms slower ❌
7% - 10%
1.95ms - 2.71ms
-

toast permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 696 kB 31.60ms - 32.09ms - faster ✔
8% - 10%
2.71ms - 3.62ms
branch 670 kB 34.63ms - 35.39ms slower ❌
8% - 11%
2.71ms - 3.62ms
-

tooltip permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 870 kB 36.42ms - 37.02ms - faster ✔
3% - 5%
1.19ms - 2.02ms
branch 825 kB 38.04ms - 38.60ms slower ❌
3% - 6%
1.19ms - 2.02ms
-

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 831 kB 25.89ms - 26.42ms - faster ✔
7% - 10%
1.97ms - 2.84ms
branch 786 kB 28.21ms - 28.91ms slower ❌
7% - 11%
1.97ms - 2.84ms
-

test-element permalink

Version Bytes Avg Time vs remote vs branch
npm latest 956 kB 54.60ms - 55.54ms - faster ✔
4% - 6%
2.37ms - 3.60ms
branch 908 kB 57.65ms - 58.45ms slower ❌
4% - 7%
2.37ms - 3.60ms
-

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 932 kB 44.31ms - 45.18ms - faster ✔
6% - 9%
2.75ms - 4.19ms
branch 884 kB 47.64ms - 48.79ms slower ❌
6% - 9%
2.75ms - 4.19ms
-

top-nav permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 689 kB 40.09ms - 40.85ms - faster ✔
5% - 9%
2.35ms - 3.84ms
branch 664 kB 42.93ms - 44.20ms slower ❌
6% - 10%
2.35ms - 3.84ms
-

truncated permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 789 kB 63.22ms - 64.76ms - faster ✔
4% - 7%
2.72ms - 4.94ms
branch 761 kB 67.02ms - 68.62ms slower ❌
4% - 8%
2.72ms - 4.94ms
-
Firefox

accordion permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 678 kB 192.44ms - 200.80ms - faster ✔
12% - 17%
26.72ms - 38.40ms
branch 682 kB 225.09ms - 233.27ms slower ❌
13% - 20%
26.72ms - 38.40ms
-

action-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 739 kB 122.02ms - 129.46ms - unsure 🔍
-8% - +0%
-10.31ms - +0.75ms
branch 713 kB 126.42ms - 134.62ms unsure 🔍
-1% - +8%
-0.75ms - +10.31ms
-

action-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 814 kB 169.97ms - 180.39ms - faster ✔
2% - 9%
3.29ms - 16.23ms
branch 768 kB 181.11ms - 188.77ms slower ❌
2% - 9%
3.29ms - 16.23ms
-

action-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 836 kB 113.56ms - 121.28ms - unsure 🔍
-7% - +2%
-8.30ms - +2.26ms
branch 791 kB 116.83ms - 124.05ms unsure 🔍
-2% - +7%
-2.26ms - +8.30ms
-

action-menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 959 kB 290.37ms - 293.87ms - faster ✔
15% - 17%
53.71ms - 60.65ms
branch 913 kB 346.31ms - 352.29ms slower ❌
18% - 21%
53.71ms - 60.65ms
-

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 917 kB 158.73ms - 163.63ms - unsure 🔍
-1% - +4%
-0.96ms - +6.20ms
branch 872 kB 155.95ms - 161.17ms unsure 🔍
-4% - +1%
-6.20ms - +0.96ms
-

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 916 kB 140.43ms - 146.25ms - faster ✔
1% - 8%
0.57ms - 12.59ms
branch 871 kB 144.66ms - 155.18ms slower ❌
0% - 9%
0.57ms - 12.59ms
-

test-open-close-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.09 MB 1896.37ms - 1901.35ms - faster ✔
0% - 1%
3.06ms - 11.50ms
branch 1.04 MB 1902.73ms - 1909.55ms slower ❌
0% - 1%
3.06ms - 11.50ms
-

test-open-close permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.09 MB 1903.61ms - 1907.27ms - faster ✔
1% - 1%
12.30ms - 19.58ms
branch 1.04 MB 1918.24ms - 1924.52ms slower ❌
1% - 1%
12.30ms - 19.58ms
-

alert-banner permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 689 kB 30.25ms - 34.03ms - unsure 🔍
-8% - +7%
-2.61ms - +2.13ms
branch 662 kB 30.96ms - 33.80ms unsure 🔍
-7% - +8%
-2.13ms - +2.61ms
-

alert-dialog permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 739 kB 209.60ms - 222.40ms - unsure 🔍
-3% - +5%
-6.67ms - +11.23ms
branch 696 kB 207.47ms - 219.97ms unsure 🔍
-5% - +3%
-11.23ms - +6.67ms
-

breadcrumbs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 979 kB 848.56ms - 869.16ms - faster ✔
2% - 4%
14.91ms - 39.45ms
branch 932 kB 879.37ms - 892.71ms slower ❌
2% - 5%
14.91ms - 39.45ms
-

button-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 731 kB 112.76ms - 123.24ms - unsure 🔍
-10% - +1%
-12.12ms - +1.20ms
branch 688 kB 119.34ms - 127.58ms unsure 🔍
-1% - +10%
-1.20ms - +12.12ms
-

button permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 739 kB 128.15ms - 134.41ms - faster ✔
0% - 8%
0.54ms - 10.46ms
branch 694 kB 132.93ms - 140.63ms slower ❌
0% - 8%
0.54ms - 10.46ms
-

card permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 781 kB 77.20ms - 81.12ms - faster ✔
1% - 9%
0.59ms - 7.65ms
branch 771 kB 80.35ms - 86.21ms slower ❌
1% - 10%
0.59ms - 7.65ms
-

checkbox permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 680 kB 105.00ms - 112.84ms - faster ✔
3% - 13%
2.84ms - 15.12ms
branch 670 kB 113.17ms - 122.63ms slower ❌
2% - 14%
2.84ms - 15.12ms
-

coachmark permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 910 kB 209.28ms - 218.36ms - unsure 🔍
-3% - +1%
-7.40ms - +3.20ms
branch 862 kB 213.19ms - 218.65ms unsure 🔍
-2% - +3%
-3.20ms - +7.40ms
-

color-field permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 756 kB 86.92ms - 92.80ms - faster ✔
3% - 10%
2.86ms - 9.82ms
branch 763 kB 94.33ms - 98.07ms slower ❌
3% - 11%
2.86ms - 9.82ms
-

combobox permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 1 MB 71.61ms - 75.35ms - faster ✔
3% - 9%
1.91ms - 7.01ms
branch 989 kB 76.21ms - 79.67ms slower ❌
2% - 10%
1.91ms - 7.01ms
-

light-dom-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1 MB 785.08ms - 797.84ms - slower ❌
4% - 8%
33.66ms - 60.30ms
branch 989 kB 732.79ms - 756.17ms faster ✔
4% - 8%
33.66ms - 60.30ms
-

contextual-help permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 944 kB 115.06ms - 123.10ms - unsure 🔍
-8% - +1%
-9.45ms - +1.21ms
branch 896 kB 119.71ms - 126.69ms unsure 🔍
-1% - +8%
-1.21ms - +9.45ms
-

dialog permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 802 kB 128.39ms - 135.77ms - unsure 🔍
-7% - +1%
-10.14ms - +1.10ms
branch 757 kB 132.36ms - 140.84ms unsure 🔍
-1% - +8%
-1.10ms - +10.14ms
-

field-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 686 kB 98.05ms - 104.99ms - unsure 🔍
-9% - +2%
-9.11ms - +1.71ms
branch 676 kB 101.07ms - 109.37ms unsure 🔍
-2% - +9%
-1.71ms - +9.11ms
-

field-label permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 651 kB 56.23ms - 60.65ms - unsure 🔍
-10% - +3%
-6.06ms - +1.90ms
branch 625 kB 57.21ms - 63.83ms unsure 🔍
-3% - +10%
-1.90ms - +6.06ms
-

help-text permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 646 kB 28.66ms - 31.22ms - unsure 🔍
-11% - +1%
-3.66ms - +0.22ms
branch 620 kB 30.20ms - 33.12ms unsure 🔍
-1% - +12%
-0.22ms - +3.66ms
-

icon permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 651 kB 38.95ms - 42.09ms - slower ❌
8% - 20%
3.00ms - 7.12ms
branch 626 kB 34.14ms - 36.78ms faster ✔
8% - 17%
3.00ms - 7.12ms
-

infield-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 661 kB 44.23ms - 47.29ms - unsure 🔍
-10% - +1%
-4.93ms - +0.33ms
branch 636 kB 45.92ms - 50.20ms unsure 🔍
-1% - +11%
-0.33ms - +4.93ms
-

menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 741 kB 410.13ms - 429.03ms - unsure 🔍
-5% - +0%
-21.44ms - +1.36ms
branch 709 kB 423.25ms - 435.99ms unsure 🔍
-0% - +5%
-1.36ms - +21.44ms
-

meter permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 668 kB 92.07ms - 97.49ms - unsure 🔍
-8% - +1%
-7.74ms - +0.98ms
branch 641 kB 94.75ms - 101.57ms unsure 🔍
-1% - +8%
-0.98ms - +7.74ms
-

number-field permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 795 kB 162.01ms - 170.35ms - faster ✔
6% - 12%
10.98ms - 21.70ms
branch 799 kB 179.16ms - 185.88ms slower ❌
6% - 13%
10.98ms - 21.70ms
-

overlay permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 1.06 MB 704.57ms - 718.51ms - slower ❌
7% - 10%
45.73ms - 64.03ms
branch 1.01 MB 650.74ms - 662.58ms faster ✔
6% - 9%
45.73ms - 64.03ms
-

directive-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.06 MB 53.90ms - 54.94ms - faster ✔
2% - 6%
1.27ms - 3.37ms
branch 1.02 MB 55.82ms - 57.66ms slower ❌
2% - 6%
1.27ms - 3.37ms
-

element-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.05 MB 705.91ms - 719.61ms - slower ❌
4% - 10%
29.10ms - 62.98ms
branch 1.01 MB 651.23ms - 682.21ms faster ✔
4% - 9%
29.10ms - 62.98ms
-

lazy-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 851 kB 94.56ms - 97.84ms - faster ✔
5% - 9%
4.79ms - 8.81ms
branch 805 kB 101.83ms - 104.17ms slower ❌
5% - 9%
4.79ms - 8.81ms
-

picker-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 674 kB 66.72ms - 72.80ms - unsure 🔍
-10% - +2%
-7.22ms - +1.30ms
branch 647 kB 69.73ms - 75.71ms unsure 🔍
-2% - +10%
-1.30ms - +7.22ms
-

picker permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 817 kB 1020.07ms - 1028.21ms - faster ✔
3% - 8%
34.93ms - 83.39ms
branch 771 kB 1059.42ms - 1107.18ms slower ❌
3% - 8%
34.93ms - 83.39ms
-

popover permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 817 kB 160.62ms - 169.58ms - unsure 🔍
-10% - +1%
-17.86ms - +2.74ms
branch 771 kB 163.38ms - 181.94ms unsure 🔍
-2% - +11%
-2.74ms - +17.86ms
-

progress-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 666 kB 67.19ms - 71.69ms - unsure 🔍
-6% - +2%
-4.32ms - +1.64ms
branch 640 kB 68.84ms - 72.72ms unsure 🔍
-2% - +6%
-1.64ms - +4.32ms
-

radio permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 663 kB 82.51ms - 89.25ms - unsure 🔍
-7% - +2%
-6.43ms - +2.23ms
branch 639 kB 85.27ms - 90.69ms unsure 🔍
-3% - +8%
-2.23ms - +6.43ms
-

search permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 737 kB 88.44ms - 93.52ms - faster ✔
3% - 11%
2.75ms - 11.13ms
branch 741 kB 94.59ms - 101.25ms slower ❌
3% - 12%
2.75ms - 11.13ms
-

slider permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 741 kB 161.89ms - 169.91ms - unsure 🔍
-6% - +1%
-9.53ms - +1.49ms
branch 715 kB 166.15ms - 173.69ms unsure 🔍
-1% - +6%
-1.49ms - +9.53ms
-

swatch permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 669 kB 35.61ms - 39.47ms - unsure 🔍
-13% - +0%
-5.41ms - +0.13ms
branch 643 kB 38.20ms - 42.16ms unsure 🔍
-1% - +15%
-0.13ms - +5.41ms
-

switch permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 657 kB 40.84ms - 43.80ms - faster ✔
1% - 11%
0.15ms - 4.81ms
branch 633 kB 43.00ms - 46.60ms slower ❌
0% - 11%
0.15ms - 4.81ms
-

table permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 802 kB 291.63ms - 306.21ms - faster ✔
4% - 9%
11.07ms - 27.85ms
branch 767 kB 314.23ms - 322.53ms slower ❌
4% - 9%
11.07ms - 27.85ms
-

tabs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 683 kB 212.01ms - 224.75ms - unsure 🔍
-4% - +4%
-9.01ms - +8.77ms
branch 658 kB 212.30ms - 224.70ms unsure 🔍
-4% - +4%
-8.77ms - +9.01ms
-

tags permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 712 kB 31.63ms - 34.85ms - unsure 🔍
-9% - +5%
-2.93ms - +1.73ms
branch 686 kB 32.16ms - 35.52ms unsure 🔍
-5% - +9%
-1.73ms - +2.93ms
-

textfield permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 693 kB 54.31ms - 58.69ms - faster ✔
8% - 19%
4.97ms - 12.51ms
branch 700 kB 62.18ms - 68.30ms slower ❌
8% - 22%
4.97ms - 12.51ms
-

toast permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 696 kB 79.85ms - 85.71ms - faster ✔
2% - 11%
2.08ms - 10.16ms
branch 670 kB 86.12ms - 91.68ms slower ❌
2% - 12%
2.08ms - 10.16ms
-

tooltip permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 956 kB 77.73ms - 81.31ms - unsure 🔍
-4% - +1%
-3.40ms - +0.92ms
branch 908 kB 79.55ms - 81.97ms unsure 🔍
-1% - +4%
-0.92ms - +3.40ms
-

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 831 kB 53.52ms - 55.16ms - faster ✔
0% - 5%
0.09ms - 2.55ms
branch 786 kB 54.74ms - 56.58ms slower ❌
0% - 5%
0.09ms - 2.55ms
-

test-element permalink

Version Bytes Avg Time vs remote vs branch
npm latest 956 kB 157.92ms - 163.44ms - slower ❌
12% - 19%
16.69ms - 25.51ms
branch 908 kB 136.14ms - 143.02ms faster ✔
11% - 16%
16.69ms - 25.51ms
-

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 932 kB 94.60ms - 97.24ms - faster ✔
17% - 24%
18.85ms - 29.27ms
branch 884 kB 114.94ms - 125.02ms slower ❌
20% - 31%
18.85ms - 29.27ms
-

top-nav permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 689 kB 102.35ms - 109.21ms - faster ✔
2% - 11%
2.47ms - 12.25ms
branch 664 kB 109.66ms - 116.62ms slower ❌
2% - 12%
2.47ms - 12.25ms
-

truncated permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 789 kB 116.21ms - 123.59ms - unsure 🔍
-8% - +0%
-10.15ms - +0.15ms
branch 761 kB 121.31ms - 128.49ms unsure 🔍
-0% - +9%
-0.15ms - +10.15ms
-

@Rajdeepc
Copy link
Contributor

Rajdeepc commented Nov 28, 2024

This is a good start but let's create a RFC on this first, we need to talk to the product teams also to make sure we are building for them and not for the component library. We can connect this PR to the RFC also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants