Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dialog): support sp-alert-dialog in sp-dialog-wrapper #4909

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lehelen19
Copy link
Contributor

@lehelen19 lehelen19 commented Nov 7, 2024

Description

Related issue(s)

resolves #4935

Motivation and context

How has this been tested?

  • Test case 1

    1. Go here
    2. Do this
  • Test case 2

    1. Go here
    2. Do this
  • Did it pass in Desktop?

  • Did it pass in Mobile?

  • Did it pass in iPad?

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

@coveralls
Copy link
Collaborator

coveralls commented Nov 7, 2024

Pull Request Test Coverage Report for Build 11721537510

Details

  • 68 of 70 (97.14%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 98.182%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/dialog/src/DialogWrapper.ts 64 66 96.97%
Totals Coverage Status
Change from base Build 11721446813: -0.007%
Covered Lines: 32337
Relevant Lines: 32761

💛 - Coveralls

@Rajdeepc
Copy link
Contributor

Hi @lehelen19 Thanks for contributing here! Can you please surface up some test links for us to verify the functionality? Also please let me know when this can be Ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat]: sp-dialog-wrapper to render sp-alert-dialog, at least the error variant
4 participants