Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Slider handler is not keyboard accessible when the slider has editable attribute #4906

Open
1 task done
Rocss opened this issue Nov 6, 2024 · 3 comments
Open
1 task done
Labels
bug Something isn't working Component: Slider needs jira ticket triage An issue needing triage

Comments

@Rocss
Copy link
Contributor

Rocss commented Nov 6, 2024

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

sp-slider

Expected behavior

Both the slider and the input should be keyboard focusable and accessible.

Actual behavior

The handler is keyboard accessible only when the slider is not editable

Screenshots

N/A

What browsers are you seeing the problem in?

Firefox, Chrome, Safari, Microsoft Edge

How can we reproduce this issue?

  1. Go to https://opensource.adobe.com/spectrum-web-components/components/slider/
  2. Navigate using the keyboard
  3. Observe there is no tab stop on the handler when the slider is editable

Sample code or abstract reproduction which illustrates the problem

Seems like this was intentional, as per

tabindex=${ifDefined(this.host.editable ? -1 : undefined)}

Severity

None

Logs taken while reproducing problem

No response

@Rocss Rocss added bug Something isn't working triage An issue needing triage needs jira ticket labels Nov 6, 2024
@jnurthen
Copy link
Member

jnurthen commented Nov 8, 2024

The intent behind this was to reduce the number of tab stops when interacting with a page - particularly one with lots of sliders as is common on photo editing applications. All of the functionality of the slider can be accomplished by interacting directly with the edit field directly and the slider will echo those changes so the slider was seen as being redundant in this case.

I'm very interested to know if this is something that was reported by a user who couldn't operate the control or if it was something reported by someone performing testing.

@najikahalsema
Copy link
Collaborator

@Rocss could you provide some context for @jnurthen above?

@Rocss
Copy link
Contributor Author

Rocss commented Nov 22, 2024

@najikahalsema I already responded on the slack thread: https://adobe.slack.com/archives/CESK60MQD/p1730713316574589

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Component: Slider needs jira ticket triage An issue needing triage
Projects
None yet
Development

No branches or pull requests

3 participants