Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Dialogs opened with sp-overlay type="page" can be dismissed with Android back #4840

Open
1 task done
hooplapunta opened this issue Oct 18, 2024 · 1 comment
Open
1 task done

Comments

@hooplapunta
Copy link

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

sp-overlay, sp-dialog-base

Expected behavior

Any dialogs opened with an overlay indicating type of "page" - i.e. do not allow dismissal: should not be dismissed with the Android back button.

Actual behavior

Dialog attribute open is removed and dialog, sp-dialog-base, sp-overlay also no longer have "open" after an Android back button.

Screenshots

No response

What browsers are you seeing the problem in?

Chrome

How can we reproduce this issue?

behavior can be observed on basic
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dialog

open dialog
use android back button to close - navigator is not triggered
same applies to any sp-dialog etc.

This is allowing users in Adobe Express to skip the landscape blocker dialog when the phone is rotated to landscape. Other similar workflows as well.

Sample code or abstract reproduction which illustrates the problem

whatwg/html#5667 (comment)
https://html.spec.whatwg.org/multipage/interaction.html#close-requests-and-close-watchers

behavior can be observed on basic
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dialog

Severity

SEV 2

Logs taken while reproducing problem

No response

@najikahalsema
Copy link
Collaborator

We historically haven't done work to support Android, so we haven't tested for this kind of use case. We'd need to test this on our side and get back to you about how we can fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants