Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Picker text overflow does not wrap according to spec #4839

Open
1 task done
itam opened this issue Oct 18, 2024 · 0 comments
Open
1 task done

[Bug]: Picker text overflow does not wrap according to spec #4839

itam opened this issue Oct 18, 2024 · 0 comments
Labels
bug Something isn't working Component: Picker Discuss w/ design Needs insight from Spectrum or another designer jira ticket created Spectrum CSS Visual Bug

Comments

@itam
Copy link

itam commented Oct 18, 2024

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

sp-picker

Expected behavior

Menu item text overflow should wrap according to:
https://spectrum.adobe.com/page/picker/#Text-overflow

Actual behavior

The menu items in sp-picker component do not wrap on text overflow

Screenshots

picker-text-overflow

What browsers are you seeing the problem in?

Chrome

How can we reproduce this issue?

Issue can be reproduced with the sample code snippet

Sample code or abstract reproduction which illustrates the problem

<sp-field-label for="picker-icons-none">Choose an action...</sp-field-label>
<sp-picker
    label="What would you like to do?"
    value="item-2"
    id="picker-icons-none"
    icons="none"
>
    <sp-menu-item>
        <sp-icon-save-floppy slot="icon"></sp-icon-save-floppy>
        Lorem ipsum dolor sit amet, consectetur adipiscing elit. Morbi varius pulvinar est, ut commodo massa dignissim rhoncus. Ut vehicula, mauris in placerat lacinia, metus dui malesuada turpis, vel aliquam justo.
    </sp-menu-item>
    <sp-menu-item>
        <sp-icon-stopwatch slot="icon"></sp-icon-stopwatch>
        Finish
    </sp-menu-item>
    <sp-menu-item>
        <sp-icon-user-activity slot="icon"></sp-icon-user-activity>
        Review
    </sp-menu-item>
</sp-picker>

Severity

SEV 4

Logs taken while reproducing problem

No response

@itam itam added bug Something isn't working needs jira ticket triage An issue needing triage labels Oct 18, 2024
@najikahalsema najikahalsema added Visual Bug Spectrum CSS Component: Picker Discuss w/ design Needs insight from Spectrum or another designer jira ticket created and removed triage An issue needing triage needs jira ticket labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Component: Picker Discuss w/ design Needs insight from Spectrum or another designer jira ticket created Spectrum CSS Visual Bug
Projects
None yet
Development

No branches or pull requests

2 participants