Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-71 - Table Styling #72

Closed
wants to merge 1 commit into from
Closed

GH-71 - Table Styling #72

wants to merge 1 commit into from

Conversation

auniverseaway
Copy link
Member

@auniverseaway auniverseaway commented Mar 11, 2022 •
edited
Loading

  • Add basic borders to tables (color scheme aware)
  • Add default margin to table to center
  • Add border collapse
  • Add very basic paragraph margins

Resolves: GH-71

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@auniverseaway
GH-71 - Table Styling
443171b 
* Add basic borders to tables (color scheme aware)
* Add default margin to table to center
* Add border collapse
* Add very basic paragraph margins

Resolves: GH-71
@auniverseaway
Copy link
Member Author

Before

Screen Shot 2022-03-10 at 6 42 20 PM

After

Screen Shot 2022-03-10 at 6 43 15 PM

@LucaNerlich
Copy link

the package.lock change does not seem right.

@auniverseaway
Copy link
Member Author

@LucaNerlich Typically you always commit package-lock updates.

@LucaNerlich
Copy link

@auniverseaway In know, just thought it seemed weird, that 6700k lines were deleted from the -lock file, without any changes to the package.json itself.

@auniverseaway
Copy link
Member Author

Closing. Can revisit later.

@rofe rofe deleted the GH-71_Table_Styling branch February 6, 2023 15:30
omprakashgupta1995 referenced this pull request in WWWPiramalFinanceCOM/piramalfinance Jul 2, 2024
@Sm1pleScr1pt
Merge pull request #72 from shamalijadhav/feature/component-creation
d6be7f2 
 tabs added on fliter level
saphalj pushed a commit to saphalj/aem-boilerplate that referenced this pull request Nov 14, 2024
@herzog31
Add PDP metadata script (adobe#72)
4b2afc7 
* Add PDP metadata script

* Add additional metadata fields

* Update hlxignore and add README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Basic Table Styling
2 participants
@auniverseaway @LucaNerlich