Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

createOptimizedPicture should set img width/height attributes #169

Open
stefanseifert opened this issue Jan 26, 2023 · 0 comments
Open

createOptimizedPicture should set img width/height attributes #169

stefanseifert opened this issue Jan 26, 2023 · 0 comments

Comments

@stefanseifert
Copy link
Contributor

Expected Behaviour

the img element generated by createOptimizedPicture should contain width/height attributes.

Actual Behaviour

the current implementation of createOptimizedPicture generates images without specifying width/height attributes - google pagespeed complains about this, and it often leads to cumulative layout shift (CLS).

please note that the actual width/height of the source image is not part the URL that is used as src input parameter, and is not contained in the data generated by query-index.
omprakashgupta1995 referenced this issue in WWWPiramalFinanceCOM/piramalfinance Jul 2, 2024
@Sm1pleScr1pt
Merge pull request #169 from shamalijadhav/feature/component-creation
3b092d7 
Feature/component creation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stefanseifert