-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to specify link target #119
Comments
I don't think this is nearly as common enough to be left to authors. In most cases, sites can formulate rules such as "all external links should open in a new window except for these hostnames", so that no one-off decisions by authors are needed. |
@trieloff , I logged this ticket based on a discussion here wherein @davidnuescheler mentioned that this has come more than once and could be considered for inclusion in the bolierplate. If we feel that isn's the case or we need to reconsider, I can close this. Else perhaps an implementation like this can be ported here, |
So the question seems to be if we can find valid use-cases for internal links to open in new tabs consistently. From the top of my head, I can think of 3 use cases that could benefit from this:
And then there is a 4th… more gray area one:
|
Expected Behaviour
Page authors should have the ability to specify the link target i.e. whether it opens in the same tab/ new tab etc in the authoring document.
Actual Behaviour
Currently there's no such ability. Developers need to implement custom logic for achieving this. For e.g. hlxsites/mmm-af@9dba400
Reproduce Scenario (including but not limited to)
Not Applicable
Steps to Reproduce
Not Applicable
Platform and Version
All
Sample Code that illustrates the problem
Not Applicable
Logs taken while reproducing problem
Not Applicable
The text was updated successfully, but these errors were encountered: