Do not expect a contents.plist file to exist in glyphs.com.adobe.type.processedglyphs #1702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be good to have something in the test suite that exercises this. @frankrolf can you add something? I can help if needed. |
|
Thank you for the offer – I will see what I can do and ask for help if needed :-) |
Only the .glif file name is really needed here, reporting the glyphDirPath probably was a mistake anyway.
… which made that comparison fail
if the layer we are working on does not contain a contents.plist, load the contents.plist from the default layer.
|
hello, I just ran into this issue again and found the pull request here - thanks @frankrolf and @josh-hadley for working on this 🖤. Can’t wait to have this improvement integrated in a future AFDKO version soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ufotoolswas assuming the contents.plist file to always exist in glyphs.com.adobe.type.processedglyphs, which may not be the case.Fixes #1606