Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpolation problems in SourceSerif4[opsz,wght].ttf #131

Open
behdad opened this issue Nov 23, 2023 · 5 comments
Open

Interpolation problems in SourceSerif4[opsz,wght].ttf #131

behdad opened this issue Nov 23, 2023 · 5 comments
Labels
addressed in source files completed in dev versions, but not yet released as fonts

Comments

@behdad
Copy link

behdad commented Nov 23, 2023

Hello!

This is an automatically-generated report about possible interpolation problems in SourceSerif4[opsz,wght].ttf, as found in the Google Fonts catalog.

To download a PDF version of this report with helpful visuals of the problems, click here; Or to view it on the GitHub website, click here.

The report follows:

Glyph uni20A6 was not compatible:
  Masters: '', 'opsz=8.0':
    Contour 0 structures differ: '', 'opsz=8.0'

This report was generated using the fonttools varLib.interpolatable tool. We understand that sometimes the tool generates false-positives. Particularly for more complicated font designs. If you did not find this report useful, please accept our apologies and ignore / close it.

To give feedback about this report, please file an issue or open a discussion at fonttools.

@behdad
Copy link
Author

behdad commented Nov 23, 2023

Sorry for the noise.

@behdad behdad closed this as completed Nov 23, 2023
@frankrolf
Copy link
Member

I was also tempted to close this at first, but I think it's worth a second look. The interpolation is fine, but you'll see that points are "wandering" (moving across a long distance).

I'll make an edit as soon as I find a moment.

@frankrolf frankrolf reopened this Nov 24, 2023
@behdad
Copy link
Author

behdad commented Nov 25, 2023

Hi Frank. Do you find this useful? It's a kink detector.

SourceSerif4[opsz,wght].ttf.pdf

@frankrolf
Copy link
Member

Hi Behdad, thank you for this. I am aware of those kinks, but I don’t think there’s a way around them (except HOI).
I have made my own kinking reporter in RoboFont, and I left those points in deliberately – otherwise, the style of the terminal would have been compromised.

It’s tempting to flag those kinks as an error since it’s technically possible – however I don’t think they are very relevant.
A typeface in which all outlines are completely smooth isn’t necessarily better than a design where kinks may occur – especially if we consider the intended application size.

With respect for this work, and without any judgment – flagging those could be interpreted as “missing the forest for the trees“. :-) Still, I think it’s useful for the designer to be informed of kinking, so they can make a decision whether they are avoidable.

@behdad
Copy link
Author

behdad commented Nov 26, 2023

Thanks Frank for the feedback. I was still tuning my tool. With current default settings it doesn't report those anymore. It does catch major kinks that the designers want to fix.

frankrolf added a commit that referenced this issue Nov 29, 2023
… not an incompatibility in the strict sense, but a mistake in the outline logic.

Fixes #131
@frankrolf frankrolf added the addressed in source files completed in dev versions, but not yet released as fonts label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addressed in source files completed in dev versions, but not yet released as fonts
Projects
None yet
Development

No branches or pull requests

2 participants