Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce the IDTA Query Language #292

Draft
wants to merge 48 commits into
base: IDTA-01002-3-1_preparation
Choose a base branch
from

Conversation

sebbader-sap
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jul 23, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
4 out of 5 committers have signed the CLA.

✅ sebbader-sap
✅ zrgt
✅ BirgitBoss
✅ aorzelskiGH
❌ waltersve
You have signed the CLA already but the status is still pending? Let us recheck it.

@@ -209,7 +209,7 @@
<FieldIdentifierString> ::= <FieldIdentifierAAS> | <FieldIdentifierSM> | <FieldIdentifierSME> | <FieldIdentifierCD> | <FieldIdentifierAasDescriptor> | <FieldIdentifierSmDescriptor>
<FieldIdentifierAAS> ::= "aas." ( "$idShort" | "$displayName." <MultiLanguageClause> | "$description." <MultiLanguageClause> | "$id" | "$assetInformation.$assetKind" | "$assetInformation.$assetType" | "$assetInformation.$globalAssetId" | "$assetInformation." <SpecificAssetIdsClause> | "$submodel." <ReferenceClause> )
<FieldIdentifierSM> ::= "sm." ( "$semanticId." <ReferenceClause> | "$idShort" | "$displayName." <MultiLanguageClause> | "description." <MultiLanguageClause> | "$id" )
<FieldIdentifierSME> ::= "sme." <idShortPath>? ( "$semanticId." <ReferenceClause> | "$idShort" | "$displayName." <MultiLanguageClause> | "$description." <MultiLanguageClause> | "$value" | "$valueType" )
<FieldIdentifierSME> ::= "sme." ( <idShortPath> ".")? ( "$semanticId." <ReferenceClause> | "$idShort" | "$displayName." <MultiLanguageClause> | "$description." <MultiLanguageClause> | "$value" | "$valueType" )
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use [] for optional parts. Do not mix [] and ? notation in AAS specs

Suggested change
<FieldIdentifierSME> ::= "sme." ( <idShortPath> ".")? ( "$semanticId." <ReferenceClause> | "$idShort" | "$displayName." <MultiLanguageClause> | "$description." <MultiLanguageClause> | "$value" | "$valueType" )
<FieldIdentifierSME> ::= "sme." [ <idShortPath> "."] ( "$semanticId." <ReferenceClause> | "$idShort" | "$displayName." <MultiLanguageClause> | "$description." <MultiLanguageClause> | "$value" | "$valueType" )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants