Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add V3.0.2 Changes to 3.1.0 #254

Merged

Conversation

sebbader-sap
Copy link
Contributor

No description provided.

@sebbader-sap
Copy link
Contributor Author

sebbader-sap commented Mar 4, 2024

Shall be merged after #253 (I just noticed I had the wrong source branch...)

@BirgitBoss BirgitBoss mentioned this pull request Mar 5, 2024
Copy link
Collaborator

@mjacoby mjacoby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some issues I am not able to decide if they are actual problems, especially the ones related to formatting as there is no way of seeing the final rendered AsciiDoc document (AFAIK).
Some other issues are not absolutely essential but the specification would greatly benefit, e.g. by reducing complexity where it is not helpful, of course without changing the behavior.

@sebbader-sap sebbader-sap added this to the 3.1 milestone Mar 12, 2024
e|https://admin-shell.io/aas/API/3/1/AssetAdministrationShellRegistryServiceSpecification/SSP-003 |Indicates that the server implemented all details of the Asset Administration Shell Registry Service Specification Bulk Profile in version 3.1.
e|https://admin-shell.io/aas/API/3/0/SubmodelRegistryServiceSpecification/SSP-001 |Indicates that the server implemented all details of the Submodel Registry Service Specification Full Profile in version 3.0.
e|https://admin-shell.io/aas/API/3/0/SubmodelRegistryServiceSpecification/SSP-002 |Indicates that the server implemented all details of the Submodel Registry Service Specification Read Profile in version 3.0.
e|https://admin-shell.io/aas/API/3/1/SubmodelRegistryServiceSpecification/SSP-003 |Indicates that the server implemented all details of the Submodel Registry Service Specification Bulk Profile in version 3.1.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add text somewhere explaining that a server can implement different versions of different service specifications?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a new task to explain it in V3.1: #264

Copy link
Collaborator

@BirgitBoss BirgitBoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

questions and minor change proposals

@sebbader-sap sebbader-sap requested a review from BirgitBoss March 22, 2024 15:56
@sebbader-sap
Copy link
Contributor Author

questions and minor change proposals

I think I responded to all your comments, please check again.

@sebbader-sap sebbader-sap merged commit 0252e57 into IDTA-01002-3-1_preparation Apr 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants