Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ValueOnly #252

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Fix ValueOnly #252

merged 2 commits into from
Mar 4, 2024

Conversation

sebbader-sap
Copy link
Contributor

Solves #251

@sebbader-sap sebbader-sap added this to the 3.0.2 milestone Mar 3, 2024
BirgitBoss
BirgitBoss approved these changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@BirgitBoss BirgitBoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure whether Schema ValueOnly is correct: empty means any object?

@sebbader-sap
Copy link
Contributor Author

Yes, "empty" in terms of "no further JSON properties specified" still means that type: object holds. Which means indeed "any object", e.g., in contrast to a JSON Array.

@sebbader-sap sebbader-sap merged commit 32dd74f into IDTA-01002-3-0_bugfix-2-preparation Mar 4, 2024
1 check passed
@sebbader-sap sebbader-sap deleted the SeBa/fix-valueonly branch March 4, 2024 18:09
@BirgitBoss
Copy link
Collaborator

#254

@g1zzm0
Copy link
Contributor

g1zzm0 commented Mar 5, 2024

Closes #251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BirgitBoss BirgitBoss BirgitBoss approved these changes

@mjacoby mjacoby Awaiting requested review from mjacoby

@alexgordtop alexgordtop Awaiting requested review from alexgordtop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@sebbader-sap @BirgitBoss @g1zzm0