Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPDATE node 20 and e15 #63

Merged

Conversation

nebur395
Copy link

  • Updating to node 20 and npm 10 in every workspace
  • Adding new workspace for es15
  • Updating typescript workspace to use es15 instead of es13
  • Updating eslint to 9
  • Updating dependencies to latest in general

import { FlatCompat } from "@eslint/eslintrc";

const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think since node 20 we can also use import.meta.dirname directly (at least it works in vite and vitest configs)
https://nodejs.org/api/esm.html#importmetadirname

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, thanks a lot :)

@@ -0,0 +1,43 @@
[![npm version](https://badge.fury.io/js/eslint-config-adidas-es13.svg)](https://npmjs.com/package/eslint-config-adidas-es13)

# eslint-config-adidas-es13
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ES15 or ES13?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@RecuencoJones RecuencoJones merged commit e57f927 into adidas:master Oct 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants