Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "primaryBreed" to parentageType #479

Open
dirbSEGES opened this issue Jun 19, 2024 · 2 comments
Open

add "primaryBreed" to parentageType #479

dirbSEGES opened this issue Jun 19, 2024 · 2 comments

Comments

@dirbSEGES
Copy link

I have a request for adding primarybreed too parentageType. This is valuable information about the animal when you are crossbreeding.

"primaryBreed": {
"$ref": "../types/icarBreedIdentifierType.json",
"description": "ICAR Breed code for the animal."

@cookeac
Copy link
Collaborator

cookeac commented Jun 27, 2024

We discussed this at the meeting on 2024-06-27 and decided

  • We can see why you might want to have this, when receiving an animal that is not on your system, with details of its parents.
  • However, why just add primaryBreed and not other components? Particularly for cross-breeding, we think that breedFractions might be more useful.
  • In general, our principle is to avoid duplicating in a resource data that is already well represented in another resource, and which can be obtained by a simple lookup.
  • However, there are some cases where it would be better to be able to pass all related data, and not require a separate API call or lookup, particularly to another system to which you may not have access.

We agreed to have a further discussion at the next meetings (2024-07-10/2024-07-11).
@dirbSEGES if you (or anyone else) has additional information or suggestions, please add further comments on this issue.

@dirbSEGES
Copy link
Author

Hi, sorry for my late reply. I've been away.

I recognize the principles of not having duplicates, but as you also mention, it is not always an option to access the data, and in our case we see this information as part of the animals' general data. We have the animals' racial fractions and are missing which of the parents contributes the fractions. Of course, adding racial fraction on the parents could also solve this, but from our perspective, we believe that primary race is enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants