Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming inconsistency in icarValidSampleFillingIndicatorType #210

Open
ahokkonen opened this issue Mar 25, 2021 · 2 comments
Open

Naming inconsistency in icarValidSampleFillingIndicatorType #210

ahokkonen opened this issue Mar 25, 2021 · 2 comments
Labels
breaking Identifies a potential breaking change that will normally be deferred until the next major release. next-major-release Confirms that an issue has been deferred until the next major version release.

Comments

@ahokkonen
Copy link
Contributor

Is there something we can do in adjusting value names for ValidSampleFillingIndicatorType?
Instead of numeric values why can't we use "Success/Incomplete /Completed" to be aligned with all the others enumerations? :)
@cookeac
Copy link
Collaborator

cookeac commented Apr 8, 2021

We discussed and agreed that this SHOULD be changed BUT would now be a breaking change. Deferred until the next major release.

@cookeac cookeac added the breaking Identifies a potential breaking change that will normally be deferred until the next major release. label Apr 8, 2021
@stale
Copy link

stale bot commented Sep 23, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale-issue Identifies that an issue is stale and will be closed unless reactivated. label Sep 23, 2021
@ahokkonen ahokkonen added the next-major-release Confirms that an issue has been deferred until the next major version release. label Oct 1, 2021
@stale stale bot removed the stale-issue Identifies that an issue is stale and will be closed unless reactivated. label Oct 1, 2021
@cookeac cookeac mentioned this issue Nov 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking Identifies a potential breaking change that will normally be deferred until the next major release. next-major-release Confirms that an issue has been deferred until the next major version release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ahokkonen @cookeac