Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add npm layer #175

Open
oliverfoster opened this issue Mar 15, 2021 · 0 comments · May be fixed by #189
Open

Add npm layer #175

oliverfoster opened this issue Mar 15, 2021 · 0 comments · May be fixed by #189
Assignees

Comments

@oliverfoster
Copy link
Member

oliverfoster commented Mar 15, 2021

Subject of the issue

All commands should work as they currently do, except that the Adapt Framework plugins should be installed using the npm client in the src/ folder with src/package.json rather than in the src/[pluginType] folders using bower and adapt.json.

SECURITY NOTE: npm install should be performed using --ignore-scripts such that no code is executed on plugin installation (AAT security). Client-side code is installed in the src/ folder so that it can not have impact on the execution of the builder.

root
├── node_modules                         Builder modules 
├── package.json                            Builder dependencies only (grunt, babel, eslint etc)
└── src
    ├── node_modules                     Client-side modules (react, adapt plugins, etc)
    └── package.json                        Client-side dependencies only (adapt plugins)   

Unresolved issues

  • AAT zip uploads and npm install pruning
  • adapt.json and its relationship to src/package.json
  • What to do with the bower registry

Other

Prototype adapt framework lives here, prototype plugins live here

@oliverfoster oliverfoster transferred this issue from adaptlearning/adapt_framework Aug 15, 2022
@oliverfoster oliverfoster moved this from Backlog to Assigned in adapt_framework: The TODO Board Aug 15, 2022
@oliverfoster oliverfoster changed the title adapt-cli: Add npm layer Add npm layer Aug 17, 2022
@cahirodoherty-learningpool cahirodoherty-learningpool moved this from Assigned to Needs Reviewing in adapt_framework: The TODO Board Apr 27, 2023
@oliverfoster oliverfoster moved this from Needs Reviewing to Assigned in adapt_framework: The TODO Board May 9, 2023
@oliverfoster oliverfoster moved this from Assigned to Backlog in adapt_framework: The TODO Board Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
5 participants