[FreshEyes] test: fix RPC coverage check #13
Conversation
|
An author commented here with:
|
![fresheyes-staging-bot[bot]](https://avatars.githubusercontent.com/in/855196?s=60&v=4){kind=small}
| @@ -829,7 +829,7 @@ def _initialize_chain(self): | |||
| cache_node_dir, | |||
| chain=self.chain, | |||
| extra_conf=["bind=127.0.0.1"], | |||
| extra_args=['-disablewallet'], | |||
There was a problem hiding this comment.
5 authors commented here with:
- comment link
https://github.com/bitcoin/bitcoin/pull/29387#discussion_r1479210925at 2024/02/06, 04:36:19 UTC - comment link
https://github.com/bitcoin/bitcoin/pull/29387#discussion_r1479350456at 2024/02/06, 07:55:10 UTC - comment link
https://github.com/bitcoin/bitcoin/pull/29387#discussion_r1479680894at 2024/02/06, 12:17:30 UTC - comment link
https://github.com/bitcoin/bitcoin/pull/29387#discussion_r1480054753at 2024/02/06, 15:40:05 UTC - comment link
https://github.com/bitcoin/bitcoin/pull/29387#discussion_r1480059345at 2024/02/06, 15:43:05 UTC.
|
An author commented here with:
|
|
An author commented here with:
|
|
This is an OUTDATED review comment as the original pull request may have been rebased or force-pushed
|
|
This is an OUTDATED review comment as the original pull request may have been rebased or force-pushed
|
|
This is an OUTDATED review comment as the original pull request may have been rebased or force-pushed
|
|
This is an OUTDATED review comment as the original pull request may have been rebased or force-pushed
|
|
This is an OUTDATED review comment as the original pull request may have been rebased or force-pushed
|
|
This is an OUTDATED review comment as the original pull request may have been rebased or force-pushed
|
|
This is an OUTDATED review comment as the original pull request may have been rebased or force-pushed
|
|
This is an OUTDATED review comment as the original pull request may have been rebased or force-pushed
|
|
An author commented here with:
|
|
An author commented here with:
|
|
An author commented here with:
|
|
An author commented here with:
|
|
This is an OUTDATED review comment as the original pull request may have been rebased or force-pushed
|
|
This is an OUTDATED review comment as the original pull request may have been rebased or force-pushed
|
|
This is an OUTDATED review comment as the original pull request may have been rebased or force-pushed
|
|
An author commented here with:
|
|
An author commented here with:
|
|
An author commented here with:
|
|
An author commented here with:
|
|
An author commented here with:
|
|
An author commented here with:
|
|
An author commented here with:
|
|
An author commented here with:
|
|
An author commented here with:
|
The author BrandonOdiwuor wrote the following PR called test: fix RPC coverage check, issue number 29387 in bitcoin/bitcoin cloned by FreshEyes below:
Fixes
https://github.com/bitcoin/bitcoin/issues/27593Currently, the RPC coverage check in functional tests doesn't include a list of all RPCs. This fix enables wallet RPCs to be included in the
rpc_interface.txtused in the coverage checkThis PR Reverses part of the changes on PR
https://github.com/bitcoin/bitcoin/pull/16042- Commithttps://github.com/bitcoin/bitcoin/pull/16042/commits/fa473303972b7dad600d949dc9b303d8136cb7e7#diff-4a04bc0b355c780033960e8c261ee9b6d3c452897e1dcd88a15d272512266c76R486to speed up cache_creation by disabling the walletUpdate:
abortrescanRPC test (commit - eb08560) to fix the failing CI due to no coverage