-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Road Continuity Issue #62
Comments
Thanks for reaching out with the detailed report about this, @markongh. Your data-fix should cause the road to show up continuously on the map the next time the Italy data-set gets processed. It normally takes about 3-4 weeks to work its way around the globe one country at a time. I flagged Italy to be refreshed sooner, so it should be updated in a few hours. While not perfect in all cases, I haven't yet hit on a better way to conceptualize a "continuous road" that doesn't use route-number or name. Route-number in particular works well for the roads in many countries as it includes most major routes that span regions -- it doesn't matter if the classification changes for sections or the name changes, as long as there is a continuous sequence with the same route number, then they can be easily joined together. Names are a bit tougher since a given region might have many roads with the same name (most towns in my area have a "Main Street" and a "High Street"). As you allude to, the name of a road may also change arbitrarily, often at municipal boundaries. Curvature only uses the name for road joining when there is not a route number, limiting the scope of this issue to smaller roads that are not part of numbered routes. It may be possible to join differently named roads together, but I think that would be only appropriate if the highway classification was the same and there weren't also other roads branching off from the same (or nearby location). For example, if a tertiary road ends and 3 residential roads split off from it near the end, it wouldn't necessarily make sense to tack on one of these residential roads to the end of the tertiary road. If the roads were all the same classification, it would be pretty easy to get wrong as well and choose to continue on a road that isn't locally though of as a continuation. A local-to-me example of a name-change on a "single road" is Bethel Mountain Road/Rochester Mountain Road/Camp Brook Road (OSM). These three sections of Tertiary road form what is locally known to be a single road, but I wouldn't want to accidentally join on the smaller "Hooper Hollow Road". I'll think about this one some more to see if I can think of ways to do this that wouldn't create "roads" that wouldn't pass a local sniff-test of being "the same road". :-) |
@adamfranco, thanks for the quick response! I think this is an awesome tool, and I can definitely appreciate the trickiness of this problem, especially after seeing the example you provided. I also have a better understanding of how/why you use the route number/name to determine road continuity. I'm glad to see that the route number was the cause of the issue for the road in Italy because it means the problem was with the OSM data and not necessarily how RoadCurvature is working. I don't know your opinion on this, but I would encourage you to have a similar philosophy of OSM of "not tagging for the renderer." In other words, build and code RoadCurvature assuming perfect and complete OSM data. If it results in highlighting some roads that are not ideal due to poor OSM data, then as these areas are explored and a fix is applied to the OSM data, it will fix the output of RoadCurvature. To offer some of my off-the-cuff thoughts: I hope that was understandable as I was still thinking through it as I wrote this haha. Hopefully it helps as you also continue to think about it. I'd love to hear your thoughts. Thanks again! |
Describe the bug
I have found at least one example of a road that is broken into multiple sections when it should be treated as a single continuous road. I suspect there could be many more.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
This road should be analyzed as one continuous road in roadcurvature.
Screenshots
Desktop (please complete the following information):
Additional context
I looked into the data in OSM and discovered that the road names and numbers were inconsistent at this sections of road and changed them to be consistent through the entire section. I am unsure if that is what was causing the continuity problem because I did this about 5 min ago and I am assuming it will take time for the change to reach all the relevant servers. However, this does cause me to wonder if you are using road names/numbers to determine where a road might start or end. I would think this should not be the case since roads can change names sometimes in the middle of a continuous section. The other possibility is that it was caused by two very short segments of road in this locations which may have caused the algorithm to not count those. I am not completely sure as I have not dug into the code (I haven't coded in over a decade), but I suspect there are other examples of this occurring which may be eliminating or reducing the curvature score of potentially awesome roads.
The text was updated successfully, but these errors were encountered: