-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does Neode.create<T>(...) async? #162
Comments
Yes |
It's in the source: https://github.com/adam-cowley/neode/blob/master/types/index.d.ts#L84, but for some reason when I
@adam-cowley do you have any ideas? Thanks! |
The create service does return a Promise so I get the feeling that |
Thanks for the reply. That's the version it installed. The same thing happens with |
I have just tried on codesandbox and it seems fine to me. Is it just the code hinting/intellisense that is out of date or is the code failing? https://codesandbox.io/s/bold-blackburn-5088nm?file=/index.js |
The code works fine without TypeScript. TypeScript compiler throws an error when it shouldn't since the line should be
instead of
I think it is some problem with the 0.4.7 distribution on NPM. The code doesn't match what is in the repo. |
I have just bumped the version number and republished, so hopefully version |
@adam-cowley That worked! Thanks. Don't want to speak for @kingpeti but I think we can close this |
when using this method it is not working as defined in TS. But when I use async-await everything is fine and the return value from
Neode.create<T>(...)
is present.To work as expected I think it needs to wrap in promise.
Am I Correct?
The text was updated successfully, but these errors were encountered: