Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reverse proxy config documentation #267

Merged
merged 3 commits into from
Dec 3, 2023

Conversation

ptpu
Copy link
Contributor

@ptpu ptpu commented Sep 27, 2023

Hey, since I've been using Actual via Traefik for a few days now, I took the time to add a little bit to the documentation in that regard. I hope it fits so far. Please feel free to comment/improve anything.

@netlify
Copy link

netlify bot commented Sep 27, 2023

Deploy Preview for actualbudget-website ready!

Name Link
🔨 Latest commit 31b8088
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget-website/deploys/65282128eed7aa0007b5ef83
😎 Deploy Preview https://deploy-preview-267.www.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check-spelling found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@github-actions

This comment has been minimized.

@ptpu
Copy link
Contributor Author

ptpu commented Sep 27, 2023

Where do i have to approve/add the unrecognized words?

@shall0pass
Copy link
Contributor

The dictionary words to allow can either be placed in:

.github/actions/spelling/expect.txt

or

.github/actions/spelling/allow/keywords.txt

@github-actions

This comment has been minimized.

Copy link

github-actions bot commented Nov 7, 2023

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
❌ dictionary-not-found 4

See ❌ Event descriptions for more information.

Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionary

This includes both expected items (37) from .github/actions/spelling/expect.txt and unrecognized words (0)

Dictionary Entries Covers Uniquely
cspell:typescript/dict/typescript.txt 1098 6 3
cspell:npm/dict/npm.txt 302 5 3
cspell:fullstack/dict/fullstack.txt 419 4 3
cspell:html/dict/html.txt 2060 7
cspell:css/dict/css.txt 263 6 1

Consider adding them (in .github/workflows/spelling.yml) for uses: check-spelling/check-spelling@main in its with:

      with:
        extra_dictionaries:
          cspell:typescript/dict/typescript.txt
          cspell:npm/dict/npm.txt
          cspell:fullstack/dict/fullstack.txt
          cspell:html/dict/html.txt
          cspell:css/dict/css.txt

To stop checking additional dictionaries, add (in .github/workflows/spelling.yml) for uses: check-spelling/check-spelling@main in its with:

check_extra_dictionaries: ''

@youngcw
Copy link
Member

youngcw commented Nov 7, 2023

@shall0pass I cant tell why the test is failing. I think everything else looks good though.

@youngcw youngcw merged commit 941838c into actualbudget:master Dec 3, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants