🐛 Fix flicker when saving transaction on account page when transactions are scheduled #3920
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
MikesGlitch
changed the title
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller
Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
| @@ -32,10 +32,6 @@ export function useAccountPreviewTransactions({ | |||
| const payees = usePayees(); | |||
|
|
|||
| const previewTransactions = useMemo(() => { | |||
| if (isLoading) { | |||
| return []; | |||
| } | |||
There was a problem hiding this comment.
This was causing the flicker - we reset the preview transactions array whenever we saved a transaction on the page. I think this is unnecessary.
WalkthroughThe pull request introduces changes to the Possibly related PRs
Suggested labels
Suggested reviewers
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
packages/desktop-client/src/hooks/useAccountPreviewTransactions.tsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-eslint-plugin". (The package "eslint-plugin-eslint-plugin" was not found when loaded as a Node module from the directory "/packages/eslint-plugin-actual".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-eslint-plugin" was referenced from the config file in "packages/eslint-plugin-actual/.eslintrc.js". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
packages/desktop-client/src/hooks/useAccountPreviewTransactions.ts (1)
51-54: LGTM! Improved loading state handlingThe restructured return statement correctly maintains the preview transactions during loading states instead of resetting them. This is a better pattern for React applications as it:
- Prevents unnecessary UI resets
- Allows components to handle loading states without losing existing data
- Reduces flickering during data updates
Consider adopting this pattern across similar hooks in the codebase where loading states are managed. Instead of resetting data during loading, let the UI components decide how to handle the loading state while preserving existing data.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
upcoming-release-notes/3920.mdis excluded by!**/*.md
📒 Files selected for processing (1)
packages/desktop-client/src/hooks/useAccountPreviewTransactions.ts(1 hunks)
🔇 Additional comments (2)
packages/desktop-client/src/hooks/useAccountPreviewTransactions.ts (2)
49-49: LGTM! Correct optimization of useMemo dependencies
The removal of isLoading from the dependency array is appropriate as the preview transactions transformation logic is independent of the loading state. This change helps prevent unnecessary recalculations and fixes the flickering issue.
49-54: Verify similar patterns in other transaction-related hooks
Let's check if other hooks in the codebase follow a similar pattern that might need the same optimization.
✅ Verification successful
No issues found with the loading state pattern
The verification shows that the loading state pattern in useAccountPreviewTransactions is consistent with other implementations in the codebase:
- The core
usePreviewTransactionshook intransactions.tsfollows the same pattern of managing loading state and returning it with preview transactions - The loading state is properly managed with state updates (
setIsLoading) and returned in a similar structure - No early returns based on loading state were found that would suggest a need for optimization
- The changes are localized and don't impact other parts of the codebase
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for similar hooks that might have early returns based on loading state
ast-grep --pattern 'export function use$_($_) {
$$$
if ($isLoading) {
return $$$
}
$$$
}'
# Look for other preview transaction related hooks
fd -e ts -e tsx -x rg -l 'usePreviewTransactions|PreviewTransactions'
Length of output: 497
Script:
#!/bin/bash
# Let's examine the content of these files to check for similar patterns
rg -U "usePreviewTransactions|PreviewTransactions" ./packages/loot-core/src/client/data-hooks/transactions.ts -A 10 -B 5
# Check the implementation in account actions
rg -U "usePreviewTransactions|PreviewTransactions" ./packages/loot-core/src/client/actions/account.ts -A 10 -B 5
# Look for loading state patterns in hooks
ast-grep --pattern 'const $isLoading = $_'
# Check for return patterns with loading state
ast-grep --pattern 'return {
$isLoading,
$$$
}'
Length of output: 2025
There was a problem hiding this comment.
Looks good to me. Maybe @joel-jeremy should look at it too if possible.
MikesGlitch
deleted the
fix/flickering-when-saving-transaction-with-scheduled
branch
Info: #3916
Fixes:
