From fc28531d4f84c2cd9d388685ba23630b38d4997c Mon Sep 17 00:00:00 2001 From: Mike Clark Date: Sun, 1 Dec 2024 17:56:41 +0000 Subject: [PATCH 1/2] fix flicker when saving transaction on account page when there are scheduled --- .../src/hooks/useAccountPreviewTransactions.ts | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/packages/desktop-client/src/hooks/useAccountPreviewTransactions.ts b/packages/desktop-client/src/hooks/useAccountPreviewTransactions.ts index ca1471c999b..d66e7687224 100644 --- a/packages/desktop-client/src/hooks/useAccountPreviewTransactions.ts +++ b/packages/desktop-client/src/hooks/useAccountPreviewTransactions.ts @@ -32,10 +32,6 @@ export function useAccountPreviewTransactions({ const payees = usePayees(); const previewTransactions = useMemo(() => { - if (isLoading) { - return []; - } - if (!accountId) { return originalPreviewTransactions; } @@ -50,9 +46,12 @@ export function useAccountPreviewTransactions({ a => a.id === payees.find(p => p.id === payeeId)?.transfer_acct, ), }); - }, [accountId, accounts, isLoading, originalPreviewTransactions, payees]); + }, [accountId, accounts, originalPreviewTransactions, payees]); - return { isLoading, previewTransactions }; + return { + isLoading, + previewTransactions, + }; } type AccountPreviewProps = { From 8ee21ddee44361575383657d4fb5f6185f4fac99 Mon Sep 17 00:00:00 2001 From: Mike Clark Date: Sun, 1 Dec 2024 17:58:55 +0000 Subject: [PATCH 2/2] release notes --- upcoming-release-notes/3920.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 upcoming-release-notes/3920.md diff --git a/upcoming-release-notes/3920.md b/upcoming-release-notes/3920.md new file mode 100644 index 00000000000..e0abd6667ce --- /dev/null +++ b/upcoming-release-notes/3920.md @@ -0,0 +1,6 @@ +--- +category: Bugfix +authors: [MikesGlitch] +--- + +Fix flickering when saving a transaction when there are transactions scheduled