Add more logging for GoCardless rate limit information #3895
Conversation
actual-github-bot
bot
changed the title
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged No assets were unchanged |
matt-fidd
changed the title
WalkthroughThe pull request introduces changes to the Possibly related PRs
Suggested labels
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
packages/loot-core/src/server/accounts/sync.tsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-eslint-plugin". (The package "eslint-plugin-eslint-plugin" was not found when loaded as a Node module from the directory "/packages/eslint-plugin-actual".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-eslint-plugin" was referenced from the config file in "packages/eslint-plugin-actual/.eslintrc.js". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (3)
packages/loot-core/src/server/accounts/sync.ts (3)
35-36: Consider using a more specific type fordetailsparameter.The addition of the optional
detailsparameter is a good improvement for error context. However, consider using a more specific type instead of the genericobjectto better document the expected structure.-function BankSyncError(type: string, code: string, details?: object) { +type ErrorDetails = { + rateLimitHeaders?: Record<string, string>; + // Add other potential detail fields here +}; +function BankSyncError(type: string, code: string, details?: ErrorDetails) {
155-159: Consider adding debug logging for rate limit headers.The addition of rate limit headers to error details is good. To further improve debugging capabilities, consider adding debug logging for the rate limit headers when they are present.
const errorDetails = { rateLimitHeaders: res.rateLimitHeaders, }; + if (res.rateLimitHeaders) { + console.log('GoCardless rate limit headers:', res.rateLimitHeaders); + } + throw BankSyncError(res.error_type, res.error_code, errorDetails);
Line range hint
211-211: Consider consistent error handling across sync providers.The SimpleFin error handling doesn't include the
detailsparameter in theBankSyncErrorcall. For consistency, consider adding error details support for SimpleFin as well.- throw BankSyncError(res.error_type, res.error_code); + const errorDetails = { + // Add relevant SimpleFin error details here + }; + throw BankSyncError(res.error_type, res.error_code, errorDetails);
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
upcoming-release-notes/3895.mdis excluded by!**/*.md
📒 Files selected for processing (1)
packages/loot-core/src/server/accounts/sync.ts(2 hunks)
actual-github-bot
bot
added
✅ Approved
🔍 Ready for review
and removed
🔍 Ready for review
✅ Approved
labels
|
thanks! |
Adds a little more information to the error printed in the console when the GoCardless rate limit is reached. I'd love to work this into the UI at some point but this is an improvement.
Complimentary server PR: actualbudget/actual-server#509
Fixes actualbudget/actual-server#488