Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix budget key tab navigation #2452

Merged
merged 2 commits into from
Mar 9, 2024
Merged

Fix budget key tab navigation #2452

merged 2 commits into from
Mar 9, 2024

Conversation

twk3
Copy link
Contributor

@twk3 twk3 commented Mar 9, 2024

  • restore the collapsed property

Fixes: #2430

Followup to: #2293

- restore the collapsed property
Copy link

netlify bot commented Mar 9, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit a89c0dd
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/65ecc16672d1650008f333b8
😎 Deploy Preview https://deploy-preview-2452.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Mar 9, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 4.43 MB → 4.43 MB (+82 B) +0.00%
Changeset
File Δ Size
src/components/budget/BudgetTable.jsx 📈 +82 B (+1.02%) 7.88 kB → 7.96 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/wide.js 270.54 kB → 270.62 kB (+82 B) +0.03%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/ButtonLink.js 379 B 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/narrow.js 79.87 kB 0%
static/js/BalanceTooltip.js 6.06 kB 0%
static/js/AppliedFilters.js 20.35 kB 0%
static/js/ReportRouter.js 1.17 MB 0%
static/js/index.js 2.75 MB 0%

Copy link
Contributor

github-actions bot commented Mar 9, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.2 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.2 MB 0%

@youngcw youngcw merged commit 998efb9 into master Mar 9, 2024
19 checks passed
@youngcw youngcw deleted the twk3/fix-budget-tab-nav branch March 9, 2024 21:19
@trafico-bot trafico-bot bot added ✅ Approved ✨ Merged Pull Request has been merged successfully and removed 🔍 Ready for Review ✨ Merged Pull Request has been merged successfully labels Mar 9, 2024
@youngcw
Copy link
Member

youngcw commented Mar 9, 2024

Oops I think that was muscle memory. Didn't mean to merge in. I hope I didn't step on your toes too much

@twk3 twk3 linked an issue Mar 9, 2024 that may be closed by this pull request
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Enter Key Does Not Move to Next Category [Bug]: Lost ability to tab between fields on Budget screen
2 participants