Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: don't show hidden income categories #1656

Merged
merged 3 commits into from
Sep 6, 2023
Merged

Mobile: don't show hidden income categories #1656

merged 3 commits into from
Sep 6, 2023

Conversation

youngcw
Copy link
Member

@youngcw youngcw commented Sep 5, 2023

Match the web view by not showing hidden income categories on mobile.

@netlify
Copy link

netlify bot commented Sep 5, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 88d786c
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/64f76f28c01f940008062730
😎 Deploy Preview https://deploy-preview-1656.demo.actualbudget.org/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
15 2.27 MB → 2.27 MB (+33 B) +0.00%
Changeset
File Δ Size
src/components/budget/MobileBudgetTable.js 📈 +54 B (+0.26%) 20.07 kB → 20.13 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/narrow-components.chunk.js 24.48 kB → 24.51 kB (+33 B) +0.13%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/main.js 968.16 kB 0%
static/js/171.chunk.js 396.24 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/894.chunk.js 145.89 kB 0%
static/js/wide-components.chunk.js 135.53 kB 0%
static/js/383.chunk.js 117.35 kB 0%
static/js/reports.chunk.js 40.54 kB 0%
static/js/969.chunk.js 12.94 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.12 kB 0%
static/css/main.css 5.82 kB 0%
asset-manifest.json 1.92 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 963 B 0%

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 2.07 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.09 MB 0%
xfo.xfo.kcab.worker.js 1004.04 kB 0%

@MatissJanis
Copy link
Member

This is a great first step, but if we're hiding them on mobile - I think we should also expose a way to toggle the visiblity. WDYT?

Screenshot 2023-09-05 at 21 33 41

@youngcw
Copy link
Member Author

youngcw commented Sep 5, 2023

I agree that a toggle would be good. That probably would be best for someone else to tackle since I was already out of my league with this change 😅

@MatissJanis
Copy link
Member

I agree that a toggle would be good. That probably would be best for someone else to tackle since I was already out of my league with this change 😅

That's fair. LGTM for your change and then hopefully someday another person will circle back here and implement the toggle :)

@MatissJanis MatissJanis merged commit bc5c2ce into actualbudget:master Sep 6, 2023
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Sep 6, 2023
@youngcw youngcw deleted the mobile_hidden_income branch September 16, 2023 20:31
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants