Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 (eslint) convert rules from ERROR to WARN to improve devX #1599

Merged
merged 6 commits into from
Sep 9, 2023
Merged

🔧 (eslint) convert rules from ERROR to WARN to improve devX #1599

merged 6 commits into from
Sep 9, 2023

Conversation

MatissJanis
Copy link
Member

Convert eslint rules from "error" to "warn" to improve dev-experience; CI jobs treat warnings as errors, so we still have the same level of protection, but the local-dev experience is slightly improved

@netlify
Copy link

netlify bot commented Aug 26, 2023 •
edited
Loading

✅ Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit a85bba3
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/64f96fef4cd601000861fdae
😎 Deploy Preview https://deploy-preview-1599.demo.actualbudget.org/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2023 •
edited
Loading

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
16 2.46 MB → 2.46 MB (-1.37 kB) -0.05%
Changeset
File Δ Size
src/components/budget/MobileBudgetTable.js 📉 -3.72 kB (-9.31%) 39.93 kB → 36.22 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
static/js/narrow-components.chunk.js 33.92 kB → 32.55 kB (-1.37 kB) -4.04%

Unchanged

Asset File Size % Changed
static/js/main.js 1.11 MB 0%
static/js/678.chunk.js 420.74 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/713.chunk.js 156.56 kB 0%
static/js/wide-components.chunk.js 125.46 kB 0%
static/js/231.chunk.js 117.37 kB 0%
static/js/reports.chunk.js 28.65 kB 0%
static/js/473.chunk.js 13 kB 0%
static/js/389.chunk.js 12.76 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.88 kB 0%
static/css/main.css 7.41 kB 0%
asset-manifest.json 2.07 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 903 B 0%

@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2023 •
edited
Loading

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 2.22 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.23 MB 0%
xfo.xfo.kcab.worker.js 1014.46 kB 0%

joel-jeremy
joel-jeremy approved these changes Sep 9, 2023
View reviewed changes
Copy link
Contributor

@joel-jeremy joel-jeremy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MatissJanis MatissJanis merged commit faa4a7c into master Sep 9, 2023
@MatissJanis MatissJanis deleted the matiss/eslint-warn branch September 9, 2023 16:54
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Sep 9, 2023
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
@MatissJanis
🔧 (eslint) convert rules from ERROR to WARN to improve devX (actualbu…
628e2a2 
…dget#1599)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joel-jeremy joel-jeremy joel-jeremy approved these changes

Assignees
No one assigned
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatissJanis @joel-jeremy