[Bug]: Simplefin sync causes incorrect new transaction highlighting on some accounts

[youngcw]

Verified issue does not already exist?

• I have searched and found no existing issue

What happened?

I think this started with the simplefin batch sync update but Im not 100% sure.

When syncing accounts if there are new transactions the account name gets bolded on the sidebar. Whats happening is that Im getting all accounts bolded that had synced transactions. The only accounts not getting bolded from the sync are accounts with all transactions reconciled, and no transactions that had not previously been synced.

Example A: This account has all reconciled transactions. The sync happens, there is nothing in the sync that is not already in the account. The account is not bolded. (Expected)

Example B: This account has some unreconciled transactions. The sync happens, new transactions are received and individually bolded because they are new. The account is bolded. (Expected)

Example C: This account has some unreconciled transactions. The sync happens, there is nothing in the sync that is not in the account. This account is bolded. (Not Expected)

How can we reproduce the issue?

I believe you could use the test credentials to do this.

1. Setup simplefin
2. Sync the test accounts. The accounts and lots of transactions should get bolded because of all the new stuff.
3. Clear out all the bolded things by refreshing or something
4. Sync again and the accounts should get bolded even though no transactions are new.

Where are you hosting Actual?

None

What browsers are you seeing the problem on?

No response

Operating System

None

[matt-fidd]

It seems likely it's related to the batch change, I did alter the logic for the transaction bolding slightly.
I can't reproduce it with the test credentials though.

Screen.Recording.2024-12-18.212248.mp4

[matt-fidd]

Ah, I can reproduce on my GoCardless accounts though, it looks like the presence of matchedTransactions triggers the boldening, not just newTransactions.

actual/packages/loot-core/src/client/actions/account.ts

Lines 226 to 231 in 11bde73

	dispatch({
	type: constants.SET_NEW_TRANSACTIONS,
	newTransactions,
	matchedTransactions,
	updatedAccounts,
	});