[Bug]: Performance regression: Accounts and Budget pages are slow

[MikesGlitch]

Verified issue does not already exist?

• I have searched and found no existing issue
• I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file)

What happened?

Navigating from an account transactions page to the budget page is extremely slow.

It was introduced by this PR: https://github.com/actualbudget/actual/pull/3864/files#diff-0305cff3699580e47a344c2d8bacf194dab7e51d925a125db9a83ad7a8b5bae1R69

When I change the deps back from:

  }, [sheetName, bindingObj.name, bindingObj.query]);

to:

  }, [sheetName, bindingObj.name]); 

I get the performance back, but it reintroduces the bug.

We need to find a way to bring the performance back without reintroducing the bug.

The performance is more obvious on the Electron app but also affects the web app.

Where are you hosting Actual?

Desktop App (Electron)

What browsers are you seeing the problem on?

Chrome, Microsoft Edge, Desktop App (Electron)

Operating System

Windows 10