Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Enhancement: Positioning delete confirmation modal component text #3796

Conversation

SpencerSedano
Copy link

Screenshot 2024-11-07 at 4 32 43 PM Screenshot 2024-11-07 at 5 07 23 PM

I've centered the ConfirmTransactionDeleteModal modal component paragraph.

The reading process of a user is easier when the text is centered because it naturally follows where the eyes are looking.

This is my first pull request, I've read the contributing docs, if there is something I missed reading, please let me know!
Thank you.

@actual-github-bot actual-github-bot bot changed the title Enhancement: Positioning delete confirmation modal component text [WIP] Enhancement: Positioning delete confirmation modal component text Nov 7, 2024
Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit e7c062b
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/672c86674d8e1900089b14e2
😎 Deploy Preview https://deploy-preview-3796.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 5.34 MB → 5.34 MB (-25 B) -0.00%
Changeset
File Δ Size
node_modules/clsx/dist/clsx.mjs 🆕 +368 B 0 B → 368 B
node_modules/clsx/dist/clsx.mjs?commonjs-proxy 🆕 +64 B 0 B → 64 B
src/components/modals/ConfirmTransactionDeleteModal.tsx 📈 +76 B (+3.88%) 1.92 kB → 1.99 kB
node_modules/react-grid-layout/build/components/WidthProvider.js 📈 +1 B (+0.02%) 5.22 kB → 5.22 kB
node_modules/react-grid-layout/build/GridItem.js 📈 +1 B (+0.00%) 21.49 kB → 21.49 kB
node_modules/react-grid-layout/build/ReactGridLayout.js 📈 +1 B (+0.00%) 24.96 kB → 24.96 kB
node_modules/clsx/dist/clsx.js 🔥 -509 B (-100%) 509 B → 0 B
node_modules/clsx/dist/clsx.js?commonjs-module 🔥 -27 B (-100%) 27 B → 0 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/ReportRouter.js 1.5 MB → 1.5 MB (+67 B) +0.00%

Smaller

Asset File Size % Changed
static/js/index.js 3.35 MB → 3.35 MB (-92 B) -0.00%

Unchanged

Asset File Size % Changed
static/js/resize-observer.js 18.37 kB 0%
static/js/workbox-window.prod.es5.js 5.69 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/usePreviewTransactions.js 1.64 kB 0%
static/js/narrow.js 82.57 kB 0%
static/js/AppliedFilters.js 21.3 kB 0%
static/js/wide.js 239.81 kB 0%

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.27 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.27 MB 0%

@joel-jeremy
Copy link
Contributor

I believe all modal texts are left aligned. If we are to change this then it might look out of place compared to the other modals. Maybe we can just make the width of the modal smaller instead?

@SpencerSedano
Copy link
Author

I would think it needs to changed in the Modal.tsx component where the minWidth is added, but I'm not sure how to make it smaller without affecting the other modal components.
If it's smaller, it would look like this:
Screenshot 2024-11-13 at 2 13 26 PM

Copy link
Contributor

👋 Hi! It looks like this PR has not had any changes for a week now. Would you like someone to review this PR? If so - please remove the "[WIP]" prefix from the PR title. That will let the community know that this PR is open for a review.

@github-actions github-actions bot added the Stale label Nov 21, 2024
Copy link
Contributor

This PR was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this Nov 26, 2024
@github-actions github-actions bot removed the Stale label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants