[Bug]: server-url related errors are not surfaced

[MatissJanis]

Verified issue does not already exist?

• I have searched and found no existing issue
• I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file)

What happened?

Screen.Recording.2024-11-04.at.18.13.15.mov

Where are you hosting Actual?

None

What browsers are you seeing the problem on?

No response

Operating System

None

[shb9019]

Hi @MatissJanis, I'd love to take this up if no one's already working on it! I believe this regression was caused due to #3736, where we're silently suppressing the URL validation error. This behavior was alluded to in #3736 (review).

[MatissJanis]

Feel free to send a PR for this. :)

[MatissJanis]

cc @MikesGlitch as an FYI

[MikesGlitch]

Oops. 😊

Yeah, I added that to fix a crash state where the user somehow had an incorrect server URL (I'm not sure how they got to that state). The joinURL function failed and they got a crashed state with no way to fix it. I think it's an edge case - but would be good if any fix could also solve that.