Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Able to download other users transaction info, even when they have end2end encryption enabled. #3778

Closed
2 tasks done
maxdalat opened this issue Nov 3, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@maxdalat
Copy link

maxdalat commented Nov 3, 2024

Verified issue does not already exist?

  • I have searched and found no existing issue
  • I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file)

What happened?

When I wanted to make a new account for someone, I tried to set up simplefin thinking that it would restart simplefin as if the other budget was separate. I found that instead, I was able to download all the transaction info, even when I didn't give my encryption key.

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Chrome

Operating System

Mac OSX

@maxdalat maxdalat added the bug Something isn't working label Nov 3, 2024
@maxdalat
Copy link
Author

maxdalat commented Nov 4, 2024

Oh what I meant by operating system, I was thinking about my laptop, sorry. In terms of docker, I am running it on a server with ubuntu 20.04 and have it connected through tailscale. I code through my laptop and open actual on my laptop. I was just thinking that this applies to any system so I didn't really think about what I put. Sorry about that confusion.

@youngcw
Copy link
Member

youngcw commented Nov 4, 2024

So you are seeing the other account's bank accounts in your simplefin account list? The file encryption key has nothing to do with simplefin, it only affects the budget files. If you want to have separate simplefin accounts you need to use different Actual servers and different simplefin accounts.

@maxdalat
Copy link
Author

maxdalat commented Nov 4, 2024

In actual documentation, it says that if you want to share the server with other people, you can set up separate budgets, and keep them separate by having encryption keys so that both need their own password. All I am asking for is a solution so that people who share a server, but have different budgets, are both able to implement simplefin completely separate from each other. I am trying to make different simplefin accounts, so that each person has their own subscription and key and everything is kept seperated. Lmk if you need any more clarification cause its kinda hard to explain.

@youngcw
Copy link
Member

youngcw commented Nov 4, 2024

As of now there can only be one simplefin connection per server. So all budget files within a server can see all transaction data from simplefin. The docs you mention don't include bank syncing, just budget files.

There is ongoing work to add user support the the server which should make it so you can have separate simplefin credentials. On simpefin's side, there is no way to select just a subset of accounts, so you would need multiple simplefin accounts to not have access to each others data, and there isn't anything Actual can do about that.

For now, the only way to not see each others data and have separate bank syncing with simplefin, is to have separate servers and separate simplefin accounts.

@youngcw youngcw closed this as completed Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants
@youngcw @maxdalat and others