fix: /update-vrt on forks #3773

UnderKoen · 2024-11-03T18:42:31Z

No description provided.

netlify · 2024-11-03T18:42:51Z

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	`4ba07bf`
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/67281b287324a4000824bc9d
😎 Deploy Preview	https://deploy-preview-3773.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2024-11-03T18:43:45Z

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
10	5.34 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/workbox-window.prod.es5.js	5.69 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/AppliedFilters.js	21.3 kB	0%
static/js/usePreviewTransactions.js	1.64 kB	0%
static/js/narrow.js	82.57 kB	0%
static/js/wide.js	238.83 kB	0%
static/js/ReportRouter.js	1.5 MB	0%
static/js/index.js	3.34 MB	0%

github-actions · 2024-11-03T18:43:46Z

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.27 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.27 MB	0%

coderabbitai · 2024-11-03T18:51:07Z

Walkthrough

The pull request modifies the GitHub Actions workflow for Visual Regression Testing (VRT) by updating the configuration in the .github/workflows/update-vrt.yml file. Key changes include the addition of a container directive that specifies the use of the Playwright Docker image mcr.microsoft.com/playwright:v1.41.1-jammy. The uses directive has been changed from xt0rted/pull-request-comment-branch@v2 to a forked version gotson/pull-request-comment-branch@head-repo-owner-dist, noted as a temporary measure until a related issue is resolved. Furthermore, the checkout step has been updated to dynamically reference the repository using outputs from a previous step, allowing the workflow to check out the appropriate branch from the pull request. The repository input now utilizes ${{ steps.comment-branch.outputs.head_owner }}/${{ steps.comment-branch.outputs.head_repo }}. The overall workflow sequence remains largely unchanged, continuing to set up the environment, wait for the Netlify build, run VRT tests, and commit any updates to snapshot images.

Possibly related PRs

ci: /update-vrt #3764: The changes in this PR involve modifications to the same workflow file (update-vrt.yml) and relate to the automation of Visual Regression Testing, making it directly relevant to the main PR's updates in the same file.

Suggested labels

:sparkles: Merged

Suggested reviewers

jfdoming
matt-fidd

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

joel-jeremy · 2024-11-03T22:57:32Z

I tried on one of the PRs and am getting this error:

https://github.com/actualbudget/actual/actions/runs/11655324670

matt-fidd · 2024-11-04T00:55:20Z

I tried on one of the PRs and am getting this error:

https://github.com/actualbudget/actual/actions/runs/11655324670

I believe this has been fixed here in ff6100c

fix: /update-vrt on forks

1824c6e

actual-github-bot bot changed the title ~~fix: /update-vrt on forks~~ [WIP] fix: /update-vrt on forks Nov 3, 2024

actual-github-bot bot added the 🚧 WIP label Nov 3, 2024

UnderKoen changed the title ~~[WIP] fix: /update-vrt on forks~~ fix: /update-vrt on forks Nov 3, 2024

actual-github-bot bot added 🔍 Ready for review and removed 🚧 WIP labels Nov 3, 2024

matt-fidd previously approved these changes Nov 3, 2024

View reviewed changes

actual-github-bot bot added ✅ Approved and removed 🔍 Ready for review labels Nov 3, 2024

chore: add missing container for /update-vrt

ff6100c

UnderKoen dismissed matt-fidd’s stale review via ff6100c November 3, 2024 21:13

actual-github-bot bot added 🔍 Ready for review and removed ✅ Approved labels Nov 3, 2024

Merge branch 'master' into ci/update-vrt

4ba07bf

matt-fidd approved these changes Nov 4, 2024

View reviewed changes

actual-github-bot bot added ✅ Approved and removed 🔍 Ready for review labels Nov 4, 2024

UnderKoen merged commit 83ceea4 into actualbudget:master Nov 4, 2024
19 of 20 checks passed

UnderKoen deleted the ci/update-vrt branch November 4, 2024 16:01

actual-github-bot bot added ✨ Merged and removed ✅ Approved labels Nov 4, 2024

This was referenced Nov 4, 2024

fix: /update-vrt #3787

Merged

ci: add reactions to /update-vrt comment #3789

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: /update-vrt on forks #3773

fix: /update-vrt on forks #3773

UnderKoen commented Nov 3, 2024

netlify bot commented Nov 3, 2024 •

edited

Loading

github-actions bot commented Nov 3, 2024 •

edited

Loading

github-actions bot commented Nov 3, 2024 •

edited

Loading

coderabbitai bot commented Nov 3, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

joel-jeremy commented Nov 3, 2024 •

edited

Loading

matt-fidd commented Nov 4, 2024

fix: /update-vrt on forks #3773

fix: /update-vrt on forks #3773

Conversation

UnderKoen commented Nov 3, 2024

netlify bot commented Nov 3, 2024 • edited Loading

✅ Deploy Preview for actualbudget ready!

github-actions bot commented Nov 3, 2024 • edited Loading

Bundle Stats — desktop-client

github-actions bot commented Nov 3, 2024 • edited Loading

Bundle Stats — loot-core

coderabbitai bot commented Nov 3, 2024 • edited Loading

Walkthrough

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

joel-jeremy commented Nov 3, 2024 • edited Loading

matt-fidd commented Nov 4, 2024

netlify bot commented Nov 3, 2024 •

edited

Loading

github-actions bot commented Nov 3, 2024 •

edited

Loading

github-actions bot commented Nov 3, 2024 •

edited

Loading

coderabbitai bot commented Nov 3, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

joel-jeremy commented Nov 3, 2024 •

edited

Loading