Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Frequency modifier for up to targets #3711

Closed
1 of 2 tasks
ColinHebert opened this issue Oct 22, 2024 · 7 comments · Fixed by #3754
Closed
1 of 2 tasks

[Feature] Frequency modifier for up to targets #3711

ColinHebert opened this issue Oct 22, 2024 · 7 comments · Fixed by #3754
Labels
feature This issue is a feature request

Comments

@ColinHebert
Copy link

ColinHebert commented Oct 22, 2024

Verified feature request does not already exist?

  • I have searched and found no existing issue

💻

  • Would you like to implement this feature?

Pitch: what problem are you trying to solve?

I am trying to replicate a behaviour of YNAB that allows doing a refill budget by $x weekly.

This would, for example, allow you to set a budget for, say, "eating out" over a month based on the number of weeks and re-fill the budget based on the number of weeks in the month.

Describe your ideal solution to this problem

Currently up to is only working "monthly" (implied), I'm wondering whether it'd be possible to have an explicit frequency set:

  • #template up to $3 daily - which would be the equivalent to #template up to $84 in February or #template up to $93 in August
  • #template up to $50 weekly - which would be the equivalent to #template up to $200 in a month with 4 weeks or #template up to $250 in a month with 5 weeks
  • #template up to $100 [monthly] - which is the current behaviour in Actual

In terms of implementation, I'm not sure it'd make sense to have frequency for longer periods of time than monthly.

Teaching and learning

No response

@ColinHebert ColinHebert added the feature This issue is a feature request label Oct 22, 2024
@github-actions github-actions bot added the needs votes Please upvote this feature request if you would like to see it implemented! label Oct 22, 2024

This comment has been minimized.

@youngcw
Copy link
Member

youngcw commented Oct 22, 2024

How would you suggest determining if there are 5 weeks or just 4 in a month? The other templates count weeks from a starting day.

@ColinHebert
Copy link
Author

ColinHebert commented Oct 22, 2024

That's a really good point.

Maybe the wording should be weekly on Monday, which would allow us to count the number of Mondays in the month.

I'm not sure what a sensible default would be if we wanted just weekly, it could either be the weekday of the first day of the month (I don't know if this would have any strong side effects) or a default to Sunday (I'm not American, but ultimately, when we count the number of weeks, Sunday is just as good as any other day). Alternatively no sensible default could work as well but I think it's a worse option.


Edit: Thinking it through, the suggestion of "first day of the month" is really bad as it means the budget would be potentially set on two days of the same weeks (end of one month beginning of the other), so I guess picking a default day when not specified is as good as anything.

@youngcw
Copy link
Member

youngcw commented Oct 23, 2024

@ColinHebert Can you try #3714 and see if it is everything you hoped for?

@Teprifer
Copy link

I like weekly on Monday type as it allows for weeklies that are on different days.

@ColinHebert
Copy link
Author

Tested and it indeed fixes this. Nicely done @youngcw !

@github-actions github-actions bot removed the needs votes Please upvote this feature request if you would like to see it implemented! label Nov 4, 2024
Copy link
Contributor

github-actions bot commented Nov 4, 2024

🎉 This feature has been implemented in #3754 and will be released in the next version. Thanks for sharing your idea! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue is a feature request
Projects
None yet
3 participants