Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Copy last month's budget not working #3688

Closed
2 tasks done
psybers opened this issue Oct 18, 2024 · 13 comments · Fixed by #3695
Closed
2 tasks done

[Bug]: Copy last month's budget not working #3688

psybers opened this issue Oct 18, 2024 · 13 comments · Fixed by #3695
Labels
bug Something isn't working

Comments

@psybers
Copy link
Contributor

psybers commented Oct 18, 2024

Verified issue does not already exist?

  • I have searched and found no existing issue
  • I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file)

What happened?

I am using tracking budget (might not be a bug for envelope).

Normally, I go to the next month around now (half way through the current month) and copy the budget over, using "copy last months budget" in the menu:

image

When I try that now, nothing happens. No errors in the JS console. Literally nothing. Just stays as zero's.

I can select the last option and set it to the 3 month average, and that works. And then I can select the second and zero it back out. But the first option does nothing at all.

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Chrome

Operating System

Mac OSX

@psybers psybers added the bug Something isn't working label Oct 18, 2024
@psybers
Copy link
Contributor Author

psybers commented Oct 18, 2024

Ok interesting follow-up: if I manually set some value in November, I can 'copy last months budget' in December and it copies it over.

So only November is broken...

@psybers
Copy link
Contributor Author

psybers commented Oct 18, 2024

First, there would be no "compatability issue" between the server in Docker and running the client in Mac. If there was any incompatibility, it would simply be the fact the client is running on mac.

Second, why would it be a "right time" issue? I already mentioned I tried it "in the middle of the month". But why would other months copy just fine and not this single month?

@youngcw
Copy link
Member

youngcw commented Oct 18, 2024

@psybers what happens if you switch to the envelope budget and add in a budget for October, then switch back to tracking and do the copy?

@psybers
Copy link
Contributor Author

psybers commented Oct 18, 2024

@youngcw Ohhhh fun. So if I do that, it copies the envelope's budget over and not the tracking budget!

@youngcw
Copy link
Member

youngcw commented Oct 18, 2024

It does that in the edge deploy too. I don't know what would have broke that, or if its just some weird edge case that just happened to come out this month

@psybers
Copy link
Contributor Author

psybers commented Oct 18, 2024

@youngcw Are you sure about that? If I load the demo budget on edge, enable tracking, set a tracking budget, then try to copy it seem to work as expected.

@youngcw
Copy link
Member

youngcw commented Oct 18, 2024

@youngcw Are you sure about that? If I load the demo budget on edge, enable tracking, set a tracking budget, then try to copy it seem to work as expected.

Thats how I knew to point it out to you

@psybers
Copy link
Contributor Author

psybers commented Oct 18, 2024

Oh interesting. It doesn't do it with the demo data, but it does it with my exported/imported data.

@youngcw
Copy link
Member

youngcw commented Oct 18, 2024

I recently merged in a copy template. Maybe try that. I don't think I tested it with the tracking budget, so it might do the same thing

@psybers
Copy link
Contributor Author

psybers commented Oct 18, 2024

I'm not looking for a way to fix this single month in my own budget. As I mentioned, it is only November that has this problem. December seems to copy just fine. I can just manually copy over the values for a single month.

I'm just trying to figure out what the bug is so we can fix it, in case it occurs more frequently later on.

@youngcw
Copy link
Member

youngcw commented Oct 19, 2024

can you try #3694 and see if it fixes your issue?

@psybers
Copy link
Contributor Author

psybers commented Oct 19, 2024

@youngcw Bingo, that fixed it. Nice job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants
@psybers @youngcw and others