Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Imported OFX incorrectly moving decimal in amounts by 4 places #3638

Closed
2 tasks done
kevinmickey opened this issue Oct 12, 2024 · 4 comments · Fixed by #3676
Closed
2 tasks done

[Bug]: Imported OFX incorrectly moving decimal in amounts by 4 places #3638

kevinmickey opened this issue Oct 12, 2024 · 4 comments · Fixed by #3676
Labels
bug Something isn't working transaction import Related to manually importing transactions

Comments

@kevinmickey
Copy link

kevinmickey commented Oct 12, 2024

Verified issue does not already exist?

  • I have searched and found no existing issue
  • I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file)

What happened?

When I import an OFX file, I see all amounts in OFX file such as $123.45 that get imported in Actual as $1,234,500.00, so the decimal is being moved 4 extra places.

I am using v24.10.1, and the OFX file includes <?OFX OFXHEADER="200" VERSION="220" ...

The amounts were imported correctly (123.45) in Actual v24.7.0. I have tested importing the same OFX file, and see a difference in Actual's behavior, so I don't believe this is due to a change by the financial institution.

Let me know if I can provide additional information.

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Firefox

Operating System

Mac OSX

@kevinmickey kevinmickey added the bug Something isn't working label Oct 12, 2024
@youngcw
Copy link
Member

youngcw commented Oct 12, 2024

Can you upload an example ofx file?

@MatissJanis MatissJanis added the needs info We need more information from the OP before continuing label Oct 12, 2024
@kevinmickey
Copy link
Author

kevinmickey commented Oct 13, 2024

Below is a test ofx file. I deleted some parts and anonymized amounts, but hopefully it should suffice. The amount 123.45 gets imported as 1,234,500, and the amount 12,345.67 gets imported as 123,456,700.

<?xml version="1.0" encoding="UTF-8" standalone="no"?><?OFX OFXHEADER="200" VERSION="220" SECURITY="NONE" OLDFILEUID="NONE" ?><OFX><SIGNONMSGSRSV1><SONRS><STATUS><CODE>0</CODE><SEVERITY>INFO</SEVERITY><MESSAGE>SUCCESS</MESSAGE></STATUS><DTSERVER>20240831000000.000[-4:EDT]</DTSERVER><LANGUAGE>ENG</LANGUAGE><FI><ORG>finame.com</ORG><FID>9999</FID></FI></SONRS></SIGNONMSGSRSV1><INVSTMTMSGSRSV1><INVSTMTTRNRS><TRNUID>9876</TRNUID><STATUS><CODE>0</CODE><SEVERITY>INFO</SEVERITY><MESSAGE>SUCCESS</MESSAGE></STATUS><INVSTMTRS><DTASOF>20240831000000.000[-4:EDT]</DTASOF><CURDEF>USD</CURDEF><INVACCTFROM><BROKERID>finame.com</BROKERID><ACCTID>123</ACCTID></INVACCTFROM><INVTRANLIST><DTSTART>20240630000000.000[-4:EDT]</DTSTART><DTEND>20240730000000.000[-4:EDT]</DTEND><INVBANKTRAN> <STMTTRN><TRNTYPE>CASH</TRNTYPE><DTPOSTED>20240716000000.000[-4:EDT]</DTPOSTED><TRNAMT>-000000000012345.6700</TRNAMT><FITID>12345</FITID><NAME>TRANS A</NAME><MEMO>TRANS A</MEMO><CURRENCY><CURRATE>1.00</CURRATE><CURSYM>USD</CURSYM></CURRENCY> </STMTTRN><SUBACCTFUND>CASH</SUBACCTFUND> </INVBANKTRAN><INVBANKTRAN> <STMTTRN><TRNTYPE>CHECK</TRNTYPE><DTPOSTED>20240716000000.000[-4:EDT]</DTPOSTED><TRNAMT>-00000000000123.4500</TRNAMT><FITID>12345</FITID><CHECKNUM>0000000001</CHECKNUM><NAME>Check Paid #0000000001</NAME><MEMO>Check Paid #0000000001</MEMO><CURRENCY><CURRATE>1.00</CURRATE><CURSYM>USD</CURSYM></CURRENCY> </STMTTRN><SUBACCTFUND>CASH</SUBACCTFUND> </INVBANKTRAN></INVTRANLIST><INVPOSLIST></INVPOSLIST><INVBAL></INVBAL></INVSTMTRS></INVSTMTTRNRS></INVSTMTMSGSRSV1></OFX>

@MatissJanis MatissJanis added help wanted Extra attention is needed transaction import Related to manually importing transactions and removed needs info We need more information from the OP before continuing labels Oct 15, 2024
@youngcw
Copy link
Member

youngcw commented Oct 15, 2024

Can you try the test build in #3676 with one of your files? It worked with the example you gave me.

@kevinmickey
Copy link
Author

It looks good when I test thru the Netlify deploy preview link. Thank you so much for your speedy fix!!

@github-actions github-actions bot removed the help wanted Extra attention is needed label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working transaction import Related to manually importing transactions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants