Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Re-Linking Bank Account (simpleFIN) to Actual Account not fetching transactions and producing error + report to Github dialogue #3228

Open
2 tasks done
R6snap opened this issue Aug 10, 2024 · 14 comments
Labels
bug Something isn't working

Comments

@R6snap
Copy link

R6snap commented Aug 10, 2024

Verified issue does not already exist?

  • I have searched and found no existing issue
  • I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file)

What happened?

A few of my accounts needed to be re-added in SimpleFIN. To re-link them in Actual, I removed the existing links, synced the server, then re-linked the accounts (both using the drop down within the account and also using the global add account > link. The account did not immediately show as linked. After a few moments, it eventually showed a green circle. When I attempted to refresh the transactions, errors began to pop up and it said to report the issue here.

(Docker container on Synology NAS)

actual-actual_server-1-2.html.zip

Where are you hosting Actual?

NAS

What browsers are you seeing the problem on?

Safari

Operating System

Mac OSX

@R6snap R6snap added the bug Something isn't working label Aug 10, 2024
@latetedemelon
Copy link

I'm having the same happen since the upgrade to 24.8.0. In fact, after (re)linking an account the account linking screen becomes blank afterwards. Upgrading to edge has the same symptoms.

@palermog
Copy link

palermog commented Sep 4, 2024

I'm having the same issue where the account linking screen becomes blank.

@muammar
Copy link

muammar commented Sep 5, 2024

I'm having the same issue where the account linking screen becomes blank.

Same here. It all was working perfectly fine before this last update.

@gittyup883
Copy link

Same issue. Kept getting "Failed syncing account" error messaged, so I reset SimpleFin token and tried unlinking and relinking accounts. But not can't relink as page is blank.

@latetedemelon
Copy link

latetedemelon commented Sep 15, 2024 via email

@Houndie
Copy link

Houndie commented Sep 19, 2024

I've also run into this error, and for me it does look like I've been rate limited.

╰─➤ curl $ACCESS_URL/accounts
{"errors":["Too many requests. SimpleFIN data is only refreshed once every 24 hours. Expected usage of this API is 24 requests per day."],"accounts":[]}%

Suggest at minimum making sure this error gets logged if it isn't already. The solution does seem pretty simple, wait until no longer rate limited. I'll wait a day or two and try again and report back.

@Houndie
Copy link

Houndie commented Sep 21, 2024

Great: I've waited a little over 24 hours, and while I still receive an error popup when syncing accounts, it does appear to still work, so rate limiting does seem to be the error reported by the poster.

That said: When I sync all accounts, the app appears to sync one account at a time. When reading the simplefin api, it appears that the accounts endpoint gives you financial data on all of your accounts. If Actual isn't already batching the syncs together when the user requests to sync multiple actual accounts simultaneously (such as when syncing "all accounts", which I would guess is a pretty common operation), it would probably be useful to do that to avoid this rate limit. If SimpleFIN Bridge doesn't want more than 24 requests in a 24 hour period, that's going to hurt users with more than 24 accounts to sync.

(That said, it's possible you do this already! This guess is based on how the app behaves, but I haven't read the code :-) )

@Houndie
Copy link

Houndie commented Sep 21, 2024

If I'm reading the code correctly, it does seem like we iterate over each account here and perform a sync on each one, which results in a large number of requests to the SimpleFIN bridge.

(It looks like gocardless is account specific so the same kind of optimization may not be helpful on that side)

@matt-fidd
Copy link
Contributor

The groundwork for batching more efficiently was laid in actualbudget/actual-server#384, there's some dev work needing to be put in on the front end to make it functional though

@Masong19hippows
Copy link

I just came across this issue as well. Weirdly enough, it wasn't happening with 24.8.0. I upgraded to 24.9.0 to see if it would fix an unrelated issue, and now I can't edit the simplefin accounts - the screen when adding is just blank. I also can't downgrade because I get an error when accessing the file with a downgraded version that I need to update the client. Its actually pretty frustrating because I don't have most of my accounts setup properly yet, and so actualbudget is unusable for me at the moment.

What I don't understand is, how come I wasn't getting rate limited before the update? It doesn't seem like the api calls changed from one version to the next, so why is rate limiting suddenly a problem? Were the SimpleFin accounts cached or something, and so the client didn't know if it was getting rate limited or not, and this was changed?

Also, did anyone find a workaround?

@Houndie
Copy link

Houndie commented Sep 30, 2024

Workaround afaik is to make sure you're not making more than 24 requests in a day 🤷 .

The batching feature mentioned above should help significantly with staying below that limit.

@Masong19hippows
Copy link

@Houndie

I emailed simplefin support and they said this

The suggested use is 24 requests/day, you will get warned at 48 requests/day and then blocked at 96 requests/day.

This is pretty high honestly. At least with my setup, it would take 10 bulk syncs of my account when I hit this limit.

I did a bulk sync of my accounts and some of the items gave an "account missing" error. I think this is just the user facing error when the limit is reached

image

I think I figured it out though. Whenever you link an account with simplefin, it does a bulk update of all of the accounts once you exit the page with the list of accounts. When I was using it, I linked one of my accounts and then exited, then I went back in and linked another - trying to make sure everything was correct. Every time I left the simplefin account list page though, it bulk updated all of my linked accounts. I thinks this just added up and I hit the limit.

@ckhordiasma
Copy link

having this issue too. started happening for me after adding about my 20th account, so probably the same root cause. would be nice to have an error message stating that we are being rate limited in addition to batched updates.

@apollo40
Copy link

apollo40 commented Oct 12, 2024

Same Problem with 24.10.1

always come to an empty page when trying to relink my Bank Account.
It works till the redirecting to the GoCardless link for approval.

Link Your Bank

To link your bank account, you will be redirected to a new page where GoCardless will ask to connect to your bank. GoCardless will not be able to withdraw funds from your accounts.

Click to Continue -> blank page

Click to Continue -> blank page

Tested with Brave, Safari and Firefox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

10 participants