Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: any/all on filters are broken #3193

Closed
2 tasks done
psybers opened this issue Aug 4, 2024 · 3 comments · Fixed by #3278
Closed
2 tasks done

[Bug]: any/all on filters are broken #3193

psybers opened this issue Aug 4, 2024 · 3 comments · Fixed by #3278
Labels
bug Something isn't working regression This bug appeared after a recent release and needs to be fixed before the next release
Milestone

Comments

@psybers
Copy link
Contributor

psybers commented Aug 4, 2024

Verified issue does not already exist?

  • I have searched and found no existing issue
  • I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file)

What happened?

  1. create a new custom report
  2. click the filter button and add a category filter of "contains t"
  3. click the filter button and add a category filter of "contains a"
  4. note that it shows both, with "all" next to the filters
  5. change "all" to "any"

Observed:
image

and the filters still behave as if "all" are selected

Expected:
it says "any" and the filters switch to "any" mode

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Chrome

Operating System

Mac OSX

@psybers psybers added the bug Something isn't working label Aug 4, 2024
@psybers
Copy link
Contributor Author

psybers commented Aug 16, 2024

This bug is a bit more widespread. The any/all issue seems to happen everywhere, regardless of filter(s) used.

@psybers psybers changed the title [Bug]: category filters break on custom reports [Bug]: any/all on filters are broken Aug 16, 2024
@psybers
Copy link
Contributor Author

psybers commented Aug 16, 2024

Chase found the commit that broke it: 14f2994

@MatissJanis thoughts?

@psybers
Copy link
Contributor Author

psybers commented Aug 16, 2024

When it breaks, you get this in the JS console:

conditionsToAQL: invalid condition: RuleError: Invalid condition field: undefined

@MatissJanis MatissJanis added the regression This bug appeared after a recent release and needs to be fixed before the next release label Aug 17, 2024
@MatissJanis MatissJanis added this to the v24.9.0 milestone Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression This bug appeared after a recent release and needs to be fixed before the next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants