-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate Account names should not be possible. #316
Comments
I've made a PR for this issue as you can see above ^ I figure the simplest way to deal with this is just to add a validation rule when creating accounts. |
👋 May I ask: why not? Why should I not be able to have two accounts with the same name if I wanted to? For example: I might have multiple accounts with the same bank. But these accounts might be of different types: checking, savings, mortgage, investments. |
How would this work for things like importing? How would you differentiate between the two accounts in a drop down? If I look in my bank I have my bank called starling but inside that is current account and savings account Having two accounts in the account register with the same name will become confusing. |
Agreed, I name mine “USAA Checking” and “USAA Savings” to disambiguate. Since people might already have duplicate account names I think we should just block any new attempts to save an account name that’s already used rather than having some preemptive approach. |
Ok, you convinced me. For import purposes it does make sense to require unique names so we could map 1:1 (we could also use account iDs for that, but it would be.. quite "clunky" experience). Should we make this a feature request? |
Or is it a bug? |
Took an executive decision, it is a bug. |
We can handle this on the front-end if we want a quick win, not sure how intense this would be for the backend/at the API level. Let me know if you want me to move to BE. Screen.Recording.2024-05-17.at.5.01.37.PM.mov |
No description provided.
The text was updated successfully, but these errors were encountered: