Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Account names should not be possible. #316

Closed
bpaulien opened this issue Dec 5, 2021 · 9 comments · Fixed by #3527
Closed

Duplicate Account names should not be possible. #316

bpaulien opened this issue Dec 5, 2021 · 9 comments · Fixed by #3527
Labels
bug Something isn't working good first issue Good for newcomers user interface Related to the user interface

Comments

@bpaulien
Copy link

bpaulien commented Dec 5, 2021

No description provided.

@rich-howell rich-howell transferred this issue from actualbudget/releases Oct 16, 2022
@rich-howell rich-howell added needs testing This needs testing and removed needs triage labels Oct 18, 2022
@DistroByte
Copy link

DistroByte commented Oct 18, 2022

Can confirm you can have duplicate account names screenshot
here

@CharlesEkkel
Copy link
Contributor

I've made a PR for this issue as you can see above ^ I figure the simplest way to deal with this is just to add a validation rule when creating accounts.

@rich-howell rich-howell moved this to Review in Actual issues Nov 7, 2022
@rich-howell rich-howell added this to the next.22.x.x milestone Nov 7, 2022
@rich-howell rich-howell added the user interface Related to the user interface label Nov 7, 2022
@MatissJanis MatissJanis removed this from the next.22.x.x milestone Jan 21, 2023
@MatissJanis
Copy link
Member

👋 May I ask: why not? Why should I not be able to have two accounts with the same name if I wanted to?

For example: I might have multiple accounts with the same bank. But these accounts might be of different types: checking, savings, mortgage, investments.

@MatissJanis MatissJanis added needs info We need more information from the OP before continuing and removed needs testing This needs testing labels May 5, 2023
@rich-howell
Copy link
Contributor

rich-howell commented May 6, 2023

👋 May I ask: why not? Why should I not be able to have two accounts with the same name if I wanted to?

For example: I might have multiple accounts with the same bank. But these accounts might be of different types: checking, savings, mortgage, investments.

How would this work for things like importing? How would you differentiate between the two accounts in a drop down?

If I look in my bank I have my bank called starling but inside that is current account and savings account

Having two accounts in the account register with the same name will become confusing.

@j-f1
Copy link
Contributor

j-f1 commented May 6, 2023

Having two accounts in the account register with the same name will become confusing

Agreed, I name mine “USAA Checking” and “USAA Savings” to disambiguate.

Since people might already have duplicate account names I think we should just block any new attempts to save an account name that’s already used rather than having some preemptive approach.

@MatissJanis
Copy link
Member

Ok, you convinced me. For import purposes it does make sense to require unique names so we could map 1:1 (we could also use account iDs for that, but it would be.. quite "clunky" experience).

Should we make this a feature request?

@rich-howell
Copy link
Contributor

Should we make this a feature request?

Or is it a bug?

@rich-howell rich-howell added bug Something isn't working and removed needs info We need more information from the OP before continuing labels May 27, 2023
@rich-howell
Copy link
Contributor

Should we make this a feature request?

Or is it a bug?

Took an executive decision, it is a bug.

@MatissJanis MatissJanis added good first issue Good for newcomers help wanted Extra attention is needed labels Aug 26, 2023
@Tigatok
Copy link
Contributor

Tigatok commented May 18, 2024

We can handle this on the front-end if we want a quick win, not sure how intense this would be for the backend/at the API level. Let me know if you want me to move to BE.

Screen.Recording.2024-05-17.at.5.01.37.PM.mov

@github-actions github-actions bot removed the help wanted Extra attention is needed label Oct 11, 2024
akgerber pushed a commit to akgerber/actual that referenced this issue Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers user interface Related to the user interface
Projects
None yet
7 participants