Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: focus ring gets "stuck" on last column of /accounts/budgeted screen. #2885

Closed
2 tasks done
miclgael opened this issue Jun 16, 2024 · 1 comment · Fixed by #3571
Closed
2 tasks done

[Bug]: focus ring gets "stuck" on last column of /accounts/budgeted screen. #2885

miclgael opened this issue Jun 16, 2024 · 1 comment · Fixed by #3571
Labels
bug Something isn't working good first issue Good for newcomers user interface Related to the user interface

Comments

@miclgael
Copy link

miclgael commented Jun 16, 2024 •
edited
Loading

Verified issue does not already exist?

  • I have searched and found no existing issue
  • I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file)

What happened?

Thanks for making Actual!

In the /accounts/budgeted screen, when tabbing through each column I get stuck at the end of the row on the [transaction cleared] column.

As a keyboard user, my expectation would be to have additional tab key presses skip down my focus to the cancel button, followed by the submit button - and loop back around to the [date] field again.

I have recorded a demo tabbing through the budget screen.

Screen.Shot.2024-06-16.at.18.58.26.mp4

I understand I can press enter/return and this will "submit" the data, however, the visual feedback and satisfying loop of watching the focus ring move to where I expect would be nice to see.

Please let me know if this is a bug or if perhaps a feature request would make more sense.

Client version: v24.6.0
Server version: v24.6.0

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Firefox

Operating System

Mac OSX
@miclgael miclgael added the bug Something isn't working label Jun 16, 2024
@miclgael miclgael changed the title [Bug]: [Bug]: focus ring gets "stuck" on last column of budgeting screen. Jun 16, 2024
@miclgael miclgael changed the title [Bug]: focus ring gets "stuck" on last column of budgeting screen. [Bug]: focus ring gets "stuck" on last column of /accounts/budgeted screen. Jun 16, 2024
@MatissJanis MatissJanis added good first issue Good for newcomers help wanted Extra attention is needed user interface Related to the user interface labels Jun 18, 2024
@MatissJanis
Copy link
Member

Thanks for the report!

Please let me know if this is a bug or if perhaps a feature request would make more sense.

I think this is a bug. We can leave the ticket as-is :)

@The-Firexx The-Firexx mentioned this issue Oct 4, 2024
Merged
joel-jeremy pushed a commit that referenced this issue Nov 12, 2024
@The-Firexx
Fixes #2885 - Focus ring getting stuck on last column of /accounts/bu…
d132440 
…dgeted (#3571)

* Fixes focus ring getting stuck on last column of /accounts/budgeted screen when creating a new transaction.

* Fix lint problems with the previous commit

* Changed the way the hook is made to the cancel and add button, removing the need to change Button2

* Changed the name of variables as mentioned in PR
@github-actions github-actions bot removed the help wanted Extra attention is needed label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers user interface Related to the user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #2885 - Focus ring getting stuck on last column of /accounts/budgeted The-Firexx/actual
2 participants
@MatissJanis @miclgael