Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usability: When accounts transactions are filtered, Select All should only select split transactions that match filter #283

Closed
bdoherty opened this issue Nov 15, 2021 · 3 comments · Fixed by #1864
Closed

Usability: When accounts transactions are filtered, Select All should only select split transactions that match filter #283

bdoherty opened this issue Nov 15, 2021 · 3 comments · Fixed by #1864
Labels
bug Something isn't working good first issue Good for newcomers transactions Related to transactions user interface Related to the user interface

Comments

@bdoherty
Copy link
Contributor

Clicking on the Select All when filtering account transactions, currently Splits that don't match the filter are selected (as well as Splits that match the filter). I came across this issue when trying to total all transactions that matched a specific category.
image

Clicking select all shows selected balance -10.00.
image

Expected result when clicking Select All. Selected balance should be -3.00.
image
@jlongster jlongster reopened this Nov 15, 2021
@jlongster
Copy link
Contributor

Sorry about the noise! Still polishing my integration :)

@jlongster jlongster reopened this Nov 16, 2021
@bdoherty
Copy link
Contributor Author

😉

@ColGra
Copy link

ColGra commented Nov 16, 2021

I agree the filtering should not include "split" items not relevant to the filter.

@rich-howell rich-howell transferred this issue from actualbudget/releases Oct 16, 2022
@rich-howell rich-howell added bug Something isn't working transactions Related to transactions user interface Related to the user interface and removed needs triage labels Oct 18, 2022
@j-f1 j-f1 mentioned this issue Jun 16, 2023
Closed
@MatissJanis MatissJanis added good first issue Good for newcomers help wanted Extra attention is needed labels Aug 26, 2023
@jamescostian jamescostian mentioned this issue Nov 6, 2023
Merged
@carkom carkom linked a pull request Nov 8, 2023 that will close this issue
Make Select All respect filters and splits #1864
Merged
@github-actions github-actions bot removed the help wanted Extra attention is needed label Nov 9, 2023
oleksandr pushed a commit to oleksandr/actual that referenced this issue Dec 30, 2023
@nudded
Add workaround for non-unique transactionIds for Belfius bank (actual…
4b12561 
…budget#283)

Co-authored-by: Toon Willems <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers transactions Related to transactions user interface Related to the user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make Select All respect filters and splits
5 participants
@jlongster @bdoherty @MatissJanis @rich-howell @ColGra