Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feedback] Spending Report #2820

Closed
carkom opened this issue Jun 2, 2024 · 42 comments · Fixed by #3611
Closed

[Feedback] Spending Report #2820

carkom opened this issue Jun 2, 2024 · 42 comments · Fixed by #3611
Labels
feedback Single feedback thread for bug reports on a new feature

Comments

@carkom
Copy link
Contributor

carkom commented Jun 2, 2024

Please use this thread to submit any feedbak you have for the spenind report.

It can be found in experimental features. Cheers!

@carkom carkom added the bug Something isn't working label Jun 2, 2024
@carkom
Copy link
Contributor Author

carkom commented Jun 2, 2024

  • Known issue: off budget payments are being counted. Need to remove them. Thanks @MatissJanis
  • Suggestion: Add "last month" as the primary line so you can see how the month ended during the 1st week of the following month.
  • Suggestion: Add ability to save the graph in some way
  • Suggestion: Add mean/median/mode
  • Suggestion: Add budget choice
  • Suggestion: Reformat UI (removing empty space and consolidating the view to match existing reports)

@carkom
Copy link
Contributor Author

carkom commented Jun 2, 2024

Suggestion: Add "last month" as the primary line so you can see how the month ended during the 1st week of the following month.

@MatissJanis MatissJanis added feedback Single feedback thread for bug reports on a new feature and removed bug Something isn't working labels Jun 3, 2024
@glowtape
Copy link

glowtape commented Jun 3, 2024

The off-budget accounts appears to my issue in #2810 . When I add them into the filter one by one, said error builds up. What's however curious is why they get excluded by filtering out an unused category.

@jsehnoutka
Copy link

Suggestion: Add ability to toggle between Payment/Deposit to monitor income as well (might also be duplicated into separate Monthly Income report)

@latetedemelon
Copy link

Suggestion: When the month turns over you no longer can review the spening vs. the previous month. I'd suggest allowing the user to review the previous months spending against the prior months as well.

@MatissJanis MatissJanis pinned this issue Jun 3, 2024
@ogielee
Copy link

ogielee commented Jun 6, 2024

Suggestion: Add income in Data table view and a surplus or deficit to highlight the difference between income and total expenses.

@shall0pass
Copy link
Contributor

When filtering by category, the only option is to compare to last month. The option to see the 3 month average disappears.

@carkom
Copy link
Contributor Author

carkom commented Jun 10, 2024

When filtering by category, the only option is to compare to last month. The option to see the 3 month average disappears.

The logic follows that you need 3 months of data for the average button to be shown. If your filter does not have transactions for the previous 3 months then average is not possible to calculate.

Example: If you filter to a category that only has transactions for this month and last month then there should not be an "average" option as there wouldn't be enough data to calculate an average.

@Waseh
Copy link

Waseh commented Jun 10, 2024

I'm only able to compare to last month. Is this intended? I have almost two years of data in Actual yet when I push (what seems to be a button) last month nothing happens.

@shall0pass
Copy link
Contributor

shall0pass commented Jun 10, 2024

When filtering by category, the only option is to compare to last month. The option to see the 3 month average disappears.

The logic follows that you need 3 months of data for the average button to be shown. If your filter does not have transactions for the previous 3 months then average is not possible to calculate.

Example: If you filter to a category that only has transactions for this month and last month then there should not be an "average" option as there wouldn't be enough data to calculate an average.

I was looking at my grocery category and have 10 years of data. The 3 month window isn't a problem. I still only get an option for last month.

Edit: I am using 24.6.0.... the edge release doesn't have this issue. Please disregard.

@carkom
Copy link
Contributor Author

carkom commented Jun 10, 2024

Edit: I am using 24.6.0.... the edge release doesn't have this issue. Please disregard.

Oh cheers! I was about to ask about edge as it was recently fixed. Thanks for confirming!

@tcjoshuafan
Copy link

Suggestion: Add option for saved/default applied filters persistent between loads/refreshes. There might be a way to do this via custom reports, but as a QOL setting OOTB for most users.

chickenscratch figma mock:
Group 128

Loving the solution btw, have it hosted on Pikapod and it's really helped. Just wish I could trigger updates myself rather than waiting for Pikapod to test first but I'll take what I can get :P

@carkom
Copy link
Contributor Author

carkom commented Jun 14, 2024

Suggestion: Add option for saved/default applied filters persistent between loads/refreshes. There might be a way to do this via custom reports, but as a QOL setting OOTB for most users.

chickenscratch figma mock:
Group 128

Loving the solution btw, have it hosted on Pikapod and it's really helped. Just wish I could trigger updates myself rather than waiting for Pikapod to test first but I'll take what I can get :P

Suggestion here is to create a saved filter in the all accounts page then you can apply it in just a few clicks.

@matt-fidd
Copy link
Contributor

For the graph to work as expected in my use case I've got to constrain it to payments and exclude deposits. Should this be a default setting?

image

Otherwise I get dips like this when I have a deposit into a category
image

@egelmex
Copy link

egelmex commented Jun 26, 2024

For me the average view would be much more useful if it showed me min/mean/max plots for the averge period. something like this.

graph_4_ex1

@christianmhunt
Copy link

Really like this feature already.

I would suggest adding a 'Compare this month to: This month's budget' line, (or just 'Budget'), which would compare spend against a linear series going from 0 on day 1 of the month, to the total budgeted amount for the month at the end of the month.

Would be handy to get a rough sense of whether you were over or underspending, on average.

@Vantarc
Copy link

Vantarc commented Jul 8, 2024

Suggestion: Add option for saved/default applied filters persistent between loads/refreshes. There might be a way to do this via custom reports, but as a QOL setting OOTB for most users.
chickenscratch figma mock:
Group 128
Loving the solution btw, have it hosted on Pikapod and it's really helped. Just wish I could trigger updates myself rather than waiting for Pikapod to test first but I'll take what I can get :P

Suggestion here is to create a saved filter in the all accounts page then you can apply it in just a few clicks.

I agree, that this would be a nice workaround, but requiring the user to click on the report and then first have to apply a filter, makes the feature unusable on the report page. Otherwise I'm really loving this feature!

@jhollowe
Copy link

jhollowe commented Jul 16, 2024

Some positive feedback from v24.7.0: it looks and works great! I tested in Dark (my default), Midnight, and even seared my eyes to check it out in Light and the theming is readable in all.

I get that Februdary is an annoying edge case to deal with, but it would be nice to have the graph go all the way to 31 days and just have shorter months plateau at the end. Even though it is only 3 or fewer days, some expenses at the end of the month can land on these days which the graph just does not show.
I'll also second the ability to easily ignore non-budget accounts and to be able to compare the current month to any arbitrary month.

@jhollowe
Copy link

jhollowe commented Jul 16, 2024

In addition to the previous month and running average, I would also like to be able to compare to this month a year ago. This would let me more closely compare seasonal expenses apples-to-apples rather than compare a mild June to a swealtering, AC-pumping July.

@carkom
Copy link
Contributor Author

carkom commented Jul 16, 2024

In addition to the previous month and running average, I would also like to be able to compare to this month a year ago. This would let me more closely compare seasonal expenses apples-to-apples rather than compare a mild June to a swealtering, AC-pumping July.

This already exists. You won't see the option if there's no data for that month last year.

@jsehnoutka
Copy link

I would advocate for allowing further user customizing of the Spending Report's scope, for example allowing to exclude some categories permanently.

I know "Saved Filters" are a workaround to this but these do not apply for the dashboard overview and still take 4 clicks to apply to the report (I hope I am not doing it wrong).

Maybe an alternative could be allowing a specific saved filter to be always applied by default to the Spending Report? That would also solve the case @matt-fidd presented and many more as that could be rather flexible.

@matt-fidd
Copy link
Contributor

I would advocate for allowing further user customizing of the Spending Report's scope, for example allowing to exclude some categories permanently.

I know "Saved Filters" are a workaround to this but these do not apply for the dashboard overview and still take 4 clicks to apply to the report (I hope I am not doing it wrong).

Maybe an alternative could be allowing a specific saved filter to be always applied by default to the Spending Report? That would also solve the case @matt-fidd presented and many more as that could be rather flexible.

That would be nice, I've got a saved filter that "fixes" it but as you say it doesn't help the dashboard. I moved some money into an off budget investment and now I'm looking at this

image

As opposed to the "fixed"
image

@jsehnoutka
Copy link

jsehnoutka commented Jul 23, 2024

It should follow the Cash Flow report logic which is omitting transfers at the moment. I recall there was a PR for that but it did not get merged (I am not sure about that). In my Spending Report transfers to off-budget accounts are also included.

@MatissJanis
Copy link
Member

MatissJanis commented Jul 30, 2024

Screenshot 2024-07-30 at 20 34 04

Some feedback about the UI:

  • red: I think the "save" button should be moved to the right side; this way it aligns with what the positioning of such actions with custom reports (and perhaps other reports too in the future)
  • green: the spacing between these labels should be aligned to be equal; also perhaps we can make the font size smaller (see "brown" point)? If we could make this legend looking closer to the cash flow graph - that would be nice
  • pink: I think these options would be better to move in the header section - besides the filters; also the label should be in bold IMO
  • brown: lots of dead whitespace here; if we could minimze it somehow - that would make the page look much better
Screenshot 2024-07-30 at 20 39 32
  • the space between active filters + the filter button is too large

Feature request:

Would be really nice to make "this month" a dynamic selector. I.e. "Compare "(select month)" with "(select another month)" OR "average".

@carkom
Copy link
Contributor Author

carkom commented Jul 31, 2024

Feature request:

Would be really nice to make "this month" a dynamic selector. I.e. "Compare "(select month)" with "(select another month)" OR "average".

@MatissJanis FYI
#3132

@carkom
Copy link
Contributor Author

carkom commented Jul 31, 2024

Some feedback about the UI:

* [ ]  red: I think the "save" button should be moved to the right side; this way it aligns with what the positioning of such actions with custom reports (and perhaps other reports too in the future)

* [ ]  green: the spacing between these labels should be aligned to be equal; also perhaps we can make the font size smaller (see "brown" point)? If we could make this legend looking closer to the cash flow graph - that would be nice

* [ ]  pink: I think these options would be better to move in the header section - besides the filters; also the label should be in bold IMO

* [ ]  brown: lots of dead whitespace here; if we could minimze it somehow - that would make the page look much better

Made updates in #3166. Cheers!

@matt-fidd
Copy link
Contributor

I think #3166 has broken the save functionality on mobile, the UI is now overlapping and you can't click the buttons any more.

image

@carkom
Copy link
Contributor Author

carkom commented Aug 6, 2024

I think #3166 has broken the save functionality on mobile, the UI is now overlapping and you can't click the buttons any more.

image

Thanks for the shout. PR submitted #3209.

@andreathniah
Copy link

The value for 'this month' is showing as negative instead of positive. Not sure if that is how it’s supposed to be?

image

@carkom
Copy link
Contributor Author

carkom commented Aug 8, 2024

The value for 'this month' is showing as negative instead of positive. Not sure if that is how it’s supposed to be?

image

Only reason for that would be if you have a big deposit (credit) in one of your spending categories.

OR your budget file has uncovered a bug that the test budget hasn't revealed.

More info is needed.

@andreathniah
Copy link

Only reason for that would be if you have a big deposit (credit) in one of your spending categories.

OR your budget file has uncovered a bug that the test budget hasn't revealed.

More info is needed.

Ah, I can confirm that there was a $2000 credit on 01-08-2024 (Day 1). Removing this credit results in the graph displaying as norm. Not a bug since it is as per intended design.

image

@youngcw youngcw closed this as completed Aug 9, 2024
@youngcw youngcw reopened this Aug 9, 2024
@matt-fidd
Copy link
Contributor

Potentially caused by the react aria migration

The selected saved pref no longer shows highlighted purple, but with no background and white text.

image

@MatissJanis MatissJanis unpinned this issue Aug 29, 2024
@nmathey
Copy link
Contributor

nmathey commented Sep 4, 2024

On the latest Actual release it shows next month name instead of this month one.
Data looks good from this month and previous one or calculated average though.
image

@MatissJanis
Copy link
Member

Feature request: legend or other visual indicator - telling you which month corresponds to which line.

Screenshot 2024-09-13 at 21 37 54

Is green line July or August? I don't know.

@matt-fidd
Copy link
Contributor

@carkom since #3380 I've not managed to get the dashboard widget working.

Report shows fine in the report view:
image

But in the dashboard:
image

@carkom
Copy link
Contributor Author

carkom commented Sep 16, 2024

Noted. We are removing this message in a coming PR which should fix this issue.

@Jonathan-Fang
Copy link
Contributor

I wanted to confirm that it's intentional that this spending report isn't compatible with turning on the experimental feature "customizable reports page (dashboards)?"

As in, if I turn on the dashboards feature I don't see the monthly spending report even if I have both checked but if I disable the dashboards feature I am able to access the monthly spending report.

@carkom
Copy link
Contributor Author

carkom commented Sep 18, 2024

I wanted to confirm that it's intentional that this spending report isn't compatible with turning on the experimental feature "customizable reports page (dashboards)?"

As in, if I turn on the dashboards feature I don't see the monthly spending report even if I have both checked but if I disable the dashboards feature I am able to access the monthly spending report.

You have to add the tile when both are enabled. Use "edit dashboard" button to add a tile.

@MatissJanis
Copy link
Member

I'm a bit late to the party, but just noticed one issue that would be great to get fixed before releasing officially:

If you create a spending report by "budget" - it uses the "budgeted" amounts. Instead I would recommend using the "balance" amounts. That's the real amount of money you actually have available in the given month. (i.e. it includes rollovers from previous months)

Thoughts?

@Jonathan-Fang
Copy link
Contributor

If I understood you correctly, why not have a way to create a spending report by "budget" and another way by "balance?"

I wouldn't want to confuse by clicking budget, and then I get balance.

@joel-rich
Copy link
Contributor

joel-rich commented Oct 11, 2024

I've discovered a strange bug where the Monthly Spending report appears to not include some transactions at the end of the month when there is a deposit.

I set up the "For budget" transaction list; filtering to a single month and excluding income categories to be able to check the "Filtered balance" total against the Monthly Spending report totals. If there are no deposits on the 30th or 31st, the totals match.

Based on a bunch of trial and error, it looks like the Monthly Spending report excludes transactions based on whether there is a deposit on the 30th or 31st.

  • If a deposit is on the 30th, all transactions from the 30th and 31st are excluded.
  • If a deposit is on the 31st, all transactions on the 31st are excluded.
  • If the last deposit of the month is on the 29th or earlier, everything works properly and all transactions from the 30th and 31st are counted.

@youngcw youngcw linked a pull request Oct 21, 2024 that will close this issue
@actualbudget actualbudget locked as off-topic and limited conversation to collaborators Oct 23, 2024
@MatissJanis
Copy link
Member

The feature has now been merged as a first-party feature. If there is any additional feedback and/or bug reports - please open separate issues.

Also if you feel like your comment in here wasn't addressed (and should have been) - please do open a separate issue.

Conversations here have been locked.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feedback Single feedback thread for bug reports on a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.