Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: ofx amount parsing does not work for foreign number formats #2800

Closed
2 tasks done
Guekka opened this issue May 25, 2024 · 3 comments · Fixed by #3044
Closed
2 tasks done

[Bug]: ofx amount parsing does not work for foreign number formats #2800

Guekka opened this issue May 25, 2024 · 3 comments · Fixed by #3044
Labels
bug Something isn't working

Comments

@Guekka
Copy link

Guekka commented May 25, 2024

Verified issue does not already exist?

  • I have searched and found no existing issue
  • I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file)

What happened?

When importing an OFX file, amounts all appear as NaN. This is due to the code using the naive Number parser: source.

Solution

Using a different parser. I saw number-parsing recommended on SO.

@Guekka Guekka added the bug Something isn't working label May 25, 2024
@youngcw
Copy link
Member

youngcw commented May 25, 2024

Can you provide an example ofx file?

@Guekka
Copy link
Author

Guekka commented May 25, 2024

Of course, gimme a minute. But any number such as -5,74 will cause a NaN

@Guekka
Copy link
Author

Guekka commented May 25, 2024

Here you go @youngcw
parsing-number-locale-issue.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants