Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Extend goal templates to calculate percentages of available funds taking into account the priority level #2437

Closed
2 tasks done
thennekx opened this issue Mar 7, 2024 · 2 comments · Fixed by #3754
Labels
feature This issue is a feature request goal templates Related to the experimental goal templates feature

Comments

@thennekx
Copy link

thennekx commented Mar 7, 2024

Verified feature request does not already exist?

  • I have searched and found no existing issue

💻

  • Would you like to implement this feature?

Pitch: what problem are you trying to solve?

The current behavior of setting a percentage of available funds does not take into account priorities set.
Priorities thus currently have no effect on the amount that is getting budgetted but rather on when it is budgetted.
This feature request is to have the option to also take into account priorities when budgetting a percentage of available funds.

The downside of current approach is that 1% of available funds on priority 99 is getting just as much budget than on priority 0.

    Requested behavior   Current behavior  
  % of available funds Assigned Available funds Assigned Available funds
Start     1000   1000
Priority 1 50% 500 500 500 Not recalculated
Priority 2 10% 50 450 100 Not recalculated
Priority 3 10% 45 405 100 Not recalculated
Priority 4 10% 40,5 364,5 100 Not recalculated

For more details and history see the issue: #2426

Describe your ideal solution to this problem

To remain backwards compatible, the current approach can be kept, as it was a deliberate choice for easier manual calculation.
For clarity towards the end user there are multiple options:

  1. A new keyword could be added like "% of available budget"
  2. The existing keyword can be extended like "% of available funds prioritized"

Teaching and learning

For simplicity to the end user a new keyword might cause less confusion and it can be explicitly mentioned that it takes into account priorities.

@thennekx thennekx added the feature This issue is a feature request label Mar 7, 2024
@github-actions github-actions bot added the needs votes Please upvote this feature request if you would like to see it implemented! label Mar 7, 2024

This comment has been minimized.

@github-actions github-actions bot closed this as completed Mar 7, 2024
@youngcw youngcw added the goal templates Related to the experimental goal templates feature label Oct 18, 2024
@github-actions github-actions bot removed the needs votes Please upvote this feature request if you would like to see it implemented! label Nov 4, 2024
Copy link
Contributor

github-actions bot commented Nov 4, 2024

🎉 This feature has been implemented in #3754 and will be released in the next version. Thanks for sharing your idea! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue is a feature request goal templates Related to the experimental goal templates feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants