Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Make comma's and period interchangeable when entering figures #2318

Closed
1 of 2 tasks
vinstaal0 opened this issue Feb 2, 2024 · 3 comments
Closed
1 of 2 tasks
Labels
feature This issue is a feature request needs votes Please upvote this feature request if you would like to see it implemented!

Comments

@vinstaal0
Copy link

Verified feature request does not already exist?

  • I have searched and found no existing issue

💻

  • Would you like to implement this feature?

Pitch: what problem are you trying to solve?

Currently when you type in a number and you press the period (when comma is the default decimal separator), it will not understand that you mean the comma. Due to differences between international keyboards and country specific keyboard it's not always possible that the comma/period on the keyboard matches with what it logically should be for that country.

For example, the Dutch keyboard layout has a comma on the number since we use commas as decimal seperators. However it does not include the € symbol. However, the international keyboard does have this on the ctrl + alt + 5 keybind.

This makes it so when you type numbers in ,say 1234,56, using the numbpad it will change it to 123456,00.

Describe your ideal solution to this problem

All finance programs I have worked with (and most other programs where you enter numbers) fix this by making the assumption that if you type in 1234.56 you actually mean 1234,56.

Not sure if it is possible, but if it is you could also check the user's keybinds to see what they have bound to numbpad.

Teaching and learning

Most people will not notice that this feature is implemented, but people will notice it hasn't been implemented.

@vinstaal0 vinstaal0 added the feature This issue is a feature request label Feb 2, 2024
@github-actions github-actions bot added the needs votes Please upvote this feature request if you would like to see it implemented! label Feb 2, 2024
Copy link
Contributor

github-actions bot commented Feb 2, 2024

✨ Thanks for sharing your idea! ✨

This repository uses lodash style issue management for enhancements. That means enhancement issues are automatically closed. This doesn’t mean we don’t accept feature requests, though! We will consider implementing ones that receive many upvotes, and we welcome contributions for any feature requests marked as needing votes (just post a comment first so we can help you make a successful contribution).

The enhancement backlog can be found here: https://github.com/actualbudget/actual/issues?q=label%3A%22needs+votes%22+sort%3Areactions-%2B1-desc+

Don’t forget to upvote the top comment with 👍!

@andriantoeff
Copy link

Seeing the need votes label in this issue: Does this feature can be said as implemented or are there still pending subtasks?

@vinstaal0
Copy link
Author

I can't test if htis is fixed since I can't currently update to the newer version (blame TrueCharts for that).

If anybody wants to test it type in 1.000,00 and see if it makes it a thousand or 100 thousand. (switch the dot and comma depending on your regional settings)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue is a feature request needs votes Please upvote this feature request if you would like to see it implemented!
Projects
None yet
Development

No branches or pull requests

2 participants