Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feedback]: Toggle Switch #2107

Closed
carkom opened this issue Dec 20, 2023 · 5 comments
Closed

[Feedback]: Toggle Switch #2107

carkom opened this issue Dec 20, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@carkom
Copy link
Contributor

carkom commented Dec 20, 2023

I've noticed that there's a few places in the app where we use a static "toggle" menu item but have no way to tell current state of that element (eg show/hide categories on budget page).

Current (both hidden and shown are the same):
image

A couple possible options here:
iconology:

Hidden Shown
OR also using dynamic text
Hidden Shown

Dynamic Text (no icons):

Hidden Shown
Toggle Switch (status follows toggle):
Hidden Shown
@carkom carkom added the bug Something isn't working label Dec 20, 2023
@carkom
Copy link
Contributor Author

carkom commented Dec 20, 2023

Maybe there's other ideas or better implementation of any of the above options?

For me, I find the iconology options a bit difficult to understand. The Dynamic text is used often in other places of the app, I don't always like that the actual state of the element in question has to be inferred by the user (example voice in my head: "okay I have an option to show hidden categories, I guess that means that they are currently not shown"). So this leaves the toggle switch which has my vote. It's simple and quick to understand and use.

I'd love to hear everyone's thoughts and preferences. Please feel free to add other options or tweak the ones I have above.

@Teprifer
Copy link

Teprifer commented Dec 20, 2023

I agree completely with your analysis.

Iconology contains too little visual differentiation, I at first thought you'd made an error in posting and put the same image in twice as I was only skimming images.

Dynamic text kinda works, but also it means there's effectively twice the UI options (and the mental processing you mentioned).

Toggle switch keeps the one UI element, is visually distinctive, is very instantly recognisable as a toggle(no mental processing). Also I like the splash of colour.

@carkom carkom changed the title [Bug]: [Feedback]: Toggle Switch Dec 20, 2023
@jsehnoutka
Copy link

+1 for toggle switch!

@youngcw
Copy link
Member

youngcw commented Feb 26, 2024

@carkom Do you need this to still be open? If we want to add toggles places maybe we should open issues for those.

@carkom
Copy link
Contributor Author

carkom commented Feb 26, 2024

Implemented in #2174

@carkom carkom closed this as completed Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants