Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emty category rule is not aplying on imported data (CSV, QFX) #2052

Closed
1 task done
Maxiimeeb opened this issue Dec 9, 2023 · 0 comments · Fixed by #2790
Closed
1 task done

Emty category rule is not aplying on imported data (CSV, QFX) #2052

Maxiimeeb opened this issue Dec 9, 2023 · 0 comments · Fixed by #2790
Labels
bug Something isn't working rules Related to rules transaction import Related to manually importing transactions

Comments

@Maxiimeeb
Copy link

Maxiimeeb commented Dec 9, 2023

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

I've encountered a bug with a rule (picture A) where uncategorized transactions are supposed to go into the General category. When I manually add a transaction, it correctly goes to General (picture B). However, when I import a CSV, it behaves differently (picture C, D, E). The bug appears to be related to the NewTransaction function sending {category: null} in JSON, while the import sets it to undefined. When the category is undefined, the eval function in packages/loot-core/src/server/accounts/rules.ts returns false (picture F).
image
b
c
d
e
f

What error did you receive?

The transaction wasn't categorised

Where are you hosting Actual?

Locally via Yarn

What browsers are you seeing the problem on?

Chrome

Operating System

Linux

@Maxiimeeb Maxiimeeb added the bug Something isn't working label Dec 9, 2023
@joel-jeremy joel-jeremy added rules Related to rules transaction import Related to manually importing transactions help wanted Extra attention is needed labels Jan 6, 2024
@twk3 twk3 closed this as completed in #2790 Jun 3, 2024
@github-actions github-actions bot removed the help wanted Extra attention is needed label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working rules Related to rules transaction import Related to manually importing transactions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants